Skip to content

Incorrect jvm_path param used when bundling with why #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 5 tasks
ykrasik opened this issue Aug 2, 2022 · 3 comments
Closed
2 of 5 tasks

Incorrect jvm_path param used when bundling with why #249

ykrasik opened this issue Aug 2, 2022 · 3 comments
Labels
bug Something isn't working fixed Issue fixed and release pending

Comments

@ykrasik
Copy link

ykrasik commented Aug 2, 2022

I'm submitting a…

  • bug report
  • feature request
  • other

Short description of the issue/suggestion:
Trying to bundle an app with a JRE using why on Windows results in a file that cannot be launched.

That's (partly) because the generated launcher.ini file uses a property jvm_path to point to the jre dir, but the why docs say it should be called jvm_install.

Steps to reproduce the issue/enhancement:

javapackager {
    bundleJre = true
    jrePath = new File(System.properties['java.home'])
    winConfig {
        exeCreationTool = 'why'
    }
}

What is the expected behavior?

What is the current behavior?

Do you have outputs, screenshots, demos or samples which demonstrate the problem or enhancement?

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • JavaPackager version: 1.6.7
  • OS version: Windows 11
  • JDK version: 1.8.0_271
  • Build tool:
    • Maven
    • Gradle

Other information (e.g. related issues, suggestions how to fix, links for us to have context)

@fvarrui
Copy link
Collaborator

fvarrui commented Aug 14, 2022

Hi @ykrasik!
Sorry for my late reply... Yes, you are right, since JavaPackager is using the last why launcher version, but launcher.ini is not updated. Thanks! I'll fix it in 1.7.0

@fvarrui fvarrui added the bug Something isn't working label Aug 14, 2022
@fvarrui
Copy link
Collaborator

fvarrui commented Aug 17, 2022

Fixed in issue-250 branch.

@fvarrui fvarrui added fixed Issue fixed and release pending feedback Waiting for feedback labels Aug 17, 2022
@fvarrui fvarrui removed the feedback Waiting for feedback label Jan 25, 2023
@fvarrui
Copy link
Collaborator

fvarrui commented Feb 8, 2023

JavaPackager 1.7.0 released to Maven Central

@fvarrui fvarrui closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Issue fixed and release pending
Projects
None yet
Development

No branches or pull requests

2 participants