Skip to content

Chapter Slider no longer work in 1.2(4) #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nokaka opened this issue Oct 9, 2024 · 9 comments · Fixed by #1281
Closed

Chapter Slider no longer work in 1.2(4) #1265

nokaka opened this issue Oct 9, 2024 · 9 comments · Fixed by #1281
Labels
bug Something isn't working

Comments

@nokaka
Copy link

nokaka commented Oct 9, 2024

Describe the bug

Chapter Slider no longer work in 1.2(4)

IMG_9842

Application version

1.2(4)

Where did you install the app from?

App Store

Device information

Chapter Slider no longer work in 1.2(4)

OS version

18.0.1

Jellyfin server version

10.9.3

@nokaka nokaka added the bug Something isn't working label Oct 9, 2024
@nokaka
Copy link
Author

nokaka commented Oct 9, 2024

IMG_9843

@LePips
Copy link
Member

LePips commented Oct 9, 2024

Does this media have chapters?

@nokaka
Copy link
Author

nokaka commented Oct 9, 2024

All chapter sliders disappeared in Swiftfin. But it works fine in jellyfin web.
IMG_9844

@zfhxi
Copy link

zfhxi commented Oct 10, 2024

I also met this problem. However, the Jellyfin Mobile (ios app) can show chaptes slider.

@nokaka
Copy link
Author

nokaka commented Oct 11, 2024

It works fine in 1.2(3)
IMG_9847
IMG_9846

@chickdan
Copy link
Contributor

chickdan commented Oct 12, 2024

I noticed this recently as well (all of the custom controls are gone), I don't know if something changed with iOS 18 or from the Jellyfin Server but media where I had previously seen chapters no longer have them. Honestly though, I don't even remember what that media was so I could be misremembering and I haven't had a chance to do any investigation.

@chickdan
Copy link
Contributor

I've traced it back to #1169 as that's when the chapters stop appearing.

@LePips
Copy link
Member

LePips commented Oct 16, 2024

Indeed, a single line change throughout the many slipped through the cracks.

@LePips
Copy link
Member

LePips commented Oct 16, 2024

Thanks for finding that. I will probably create a 1.2.1 branch for that small fix based off the 1.2 tag and the iOS 18 icon fix (since I got the wrong commit) instead of waiting for 1.3, as I want my video player refactor to be in that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants