Skip to content

Commit 779d05c

Browse files
authored
Merge pull request #156 from jeremykenedy/analysis-djWDQg
2 parents 412b781 + eeabb8c commit 779d05c

File tree

1 file changed

+25
-25
lines changed

1 file changed

+25
-25
lines changed

src/App/Http/Controllers/LaravelLoggerController.php

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,12 @@ public function showAccessLog(Request $request)
8686

8787
self::mapAdditionalDetails($activities);
8888

89-
90-
if(config('LaravelLogger.enableLiveSearch')){
91-
// We are querying only the paginated userIds because in a big application querying all user data is performance heavy
92-
$user_ids = array_unique($activities->pluck('userId')->toArray());
93-
$users = config('LaravelLogger.defaultUserModel')::whereIn(config('LaravelLogger.defaultUserIDField'), $user_ids)->get();
94-
}else{
95-
$users = config('LaravelLogger.defaultUserModel')::all();
89+
if (config('LaravelLogger.enableLiveSearch')) {
90+
// We are querying only the paginated userIds because in a big application querying all user data is performance heavy
91+
$user_ids = array_unique($activities->pluck('userId')->toArray());
92+
$users = config('LaravelLogger.defaultUserModel')::whereIn(config('LaravelLogger.defaultUserIDField'), $user_ids)->get();
93+
} else {
94+
$users = config('LaravelLogger.defaultUserModel')::all();
9695
}
9796

9897
$data = [
@@ -312,22 +311,23 @@ public function searchActivityLog($query, $request)
312311
}
313312

314313
return $query;
315-
}
316-
/**
317-
* Search the database users according to specific criteria.
318-
*
319-
* @param request
320-
*
321-
* @return filtered user data
322-
*/
323-
public function liveSearch(Request $request){
324-
325-
$filteredUsers = config('LaravelLogger.defaultUserModel')::when(request('userid'), function ($q) {
326-
return $q->where(config('LaravelLogger.defaultUserIDField'), (int) request('userid', 0));
327-
})->when(request('email'), function ($q) {
328-
return $q->where('email', 'like', '%' . request('email') . '%');
329-
});
330-
331-
return response()->json($filteredUsers->get()->pluck('email', config('LaravelLogger.defaultUserIDField')), 200);
332-
}
314+
}
315+
316+
/**
317+
* Search the database users according to specific criteria.
318+
*
319+
* @param request
320+
*
321+
* @return filtered user data
322+
*/
323+
public function liveSearch(Request $request)
324+
{
325+
$filteredUsers = config('LaravelLogger.defaultUserModel')::when(request('userid'), function ($q) {
326+
return $q->where(config('LaravelLogger.defaultUserIDField'), (int) request('userid', 0));
327+
})->when(request('email'), function ($q) {
328+
return $q->where('email', 'like', '%'.request('email').'%');
329+
});
330+
331+
return response()->json($filteredUsers->get()->pluck('email', config('LaravelLogger.defaultUserIDField')), 200);
332+
}
333333
}

0 commit comments

Comments
 (0)