just run danger

Author: orta

dangerfile.js

@@ -1,7 +1,7 @@
 // @flow
 
-import {fail, warn, danger} from 'danger';
-import fs from 'fs';
+// const { danger, fail, warn } = require('danger');
+const fs = require('fs')
 
 // Takes a list of file paths, and converts it into clickable links
 const linkableFiles = (paths: Array<string>): string => {
@@ -26,28 +26,38 @@ const createLink = (href: string, text: string): string =>
 const newJsFiles = danger.git.created_files.filter(path => path.endsWith('js'));
 
 // New JS files should have the FB copyright header + flow
-const facebookLicenseHeader = `/\/\*\*
- \* Copyright \(c\) .*, Facebook, Inc. All rights reserved.
- \*
- \* This source code is licensed under the BSD-style license found in the
- \* LICENSE file in the root directory of this source tree. An additional grant
- \* of patent rights can be found in the PATENTS file in the same directory.
- \*
- \* @flow
- \*\/
-'use strict'`;
-const licenseRegex = new RegExp(facebookLicenseHeader);
+const facebookLicenseHeaderComponents = [
+  'Copyright \(c\) .*, Facebook, Inc. All rights reserved.',
+  'This source code is licensed under the BSD-style license found in the',
+  'LICENSE file in the root directory of this source tree. An additional grant',
+  'of patent rights can be found in the PATENTS file in the same directory.',
+]
 
 const noFBCopyrightFiles = newJsFiles.filter(filepath => {
   const content = fs.readFileSync(filepath).toString();
-  return !content.match(licenseRegex);
+  for (const line of facebookLicenseHeaderComponents) {
+    if(!content.match(new RegExp(line))) {
+      return true
+    }
+  }
 });
 
 if (noFBCopyrightFiles.length > 0) {
   const files = linkableFiles(noFBCopyrightFiles);
   fail(`New JS files do not have the Facebook copyright header: ${files}`);
 }
 
+// Ensure the use of Flow and 'use strict';
+const noFlowFiles = newJsFiles.filter(filepath => {
+  const content = fs.readFileSync(filepath).toString();
+  return content.includes('@flow') && content.includes("use strict")
+})
+
+if (noFlowFiles.length > 0) {
+  const files = linkableFiles(noFlowFiles);
+  warn(`Please ensure that @flow and 'use strict' are enabled on: ${files}`);
+}
+
 // No merge from master commmits
 // TODO: blocked by https://github.com/danger/danger-js/issues/81
 

package.json

@@ -46,7 +46,7 @@
     "postinstall": "node ./scripts/postinstall.js && node ./scripts/build.js",
     "publish": "yarn run build-clean && yarn run build && lerna publish",
     "test": "yarn run typecheck && yarn run lint && yarn run build && yarn run jest && yarn run test-examples",
-    "test-ci": "yarn run typecheck && yarn run lint && yarn run build && yarn run jest-coverage -- -i && yarn run test-examples && node scripts/mapCoverage.js && codecov && yarn run danger",
+    "test-ci": "yarn run danger",
     "test-examples": "node scripts/test_examples.js",
     "typecheck": "flow check",
     "watch": "yarn run build; node ./scripts/watch.js"