Skip to content

Commit 594e0d8

Browse files
committed
Refactor vars handling when adding C/C++ build rules.
1 parent 2bdc70d commit 594e0d8

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

ninja.lua

+8-6
Original file line numberDiff line numberDiff line change
@@ -565,19 +565,21 @@ local function compile_file_build(cfg, filecfg, toolset, pch_dependency, regular
565565
elseif shouldcompileasc(filecfg) then
566566
local objfilename = obj_dir .. "/" .. filecfg.objname .. (toolset.objectextension or ".o")
567567
objfiles[#objfiles + 1] = objfilename
568-
local cflags = {}
568+
local vars = {}
569569
if has_custom_settings then
570-
cflags = {"CFLAGS = $CFLAGS " .. getcflags(toolset, cfg, filecfg)}
570+
cflags = "CFLAGS = $CFLAGS " .. getcflags(toolset, cfg, filecfg)
571+
vars = { cflags }
571572
end
572-
ninja.add_build(cfg, objfilename, {}, iif(use_clangtidy, "clangtidy_cc", "cc"), {filepath}, pch_dependency, regular_file_dependencies, cflags)
573+
ninja.add_build(cfg, objfilename, {}, iif(use_clangtidy, "clangtidy_cc", "cc"), {filepath}, pch_dependency, regular_file_dependencies, vars)
573574
elseif shouldcompileascpp(filecfg) then
574575
local objfilename = obj_dir .. "/" .. filecfg.objname .. (toolset.objectextension or ".o")
575576
objfiles[#objfiles + 1] = objfilename
576-
local cxxflags = {}
577+
local vars = {}
577578
if has_custom_settings then
578-
cxxflags = {"CXXFLAGS = $CXXFLAGS " .. getcxxflags(toolset, cfg, filecfg)}
579+
cxxflags = "CXXFLAGS = $CXXFLAGS " .. getcxxflags(toolset, cfg, filecfg)
580+
vars = { cxxflags }
579581
end
580-
ninja.add_build(cfg, objfilename, {}, iif(use_clangtidy, "clangtidy_cxx", "cxx"), {filepath}, pch_dependency, regular_file_dependencies, cxxflags)
582+
ninja.add_build(cfg, objfilename, {}, iif(use_clangtidy, "clangtidy_cxx", "cxx"), {filepath}, pch_dependency, regular_file_dependencies, vars)
581583
elseif path.isresourcefile(filecfg.abspath) then
582584
local objfilename = obj_dir .. "/" .. filecfg.basename .. ".res"
583585
objfiles[#objfiles + 1] = objfilename

0 commit comments

Comments
 (0)