Replies: 1 comment
-
Some ideas were discussed in #2801, but I don't have strong feeling. I personally don't like |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I'd like to call attention to what I as a new user of jj think is a minor inconsistency
in the CLI. In commit a39dd0f,
jj workspace root
wasduplicated to
jj root
. The commit message seems to suggest that the task of printingdifferent types of root paths should be under the purview of
jj root
:However, that is not currently the case.
jj root
prints the workspace root only andthe options for printing other kinds of roots are spread out into the subcommands of
jj workspace
andjj git
.In short, the current state is that
jj root
exists but is limited, while other roottypes are found under separate command groups (
jj workspace
,jj git
). This leads toa discoverability problem for new users:
jj root
intuitively suggests it might be a generalcommand for finding any kind of relevant root path in the repository or workspace.
jj root --help
confirms it only does the workspace root and provides no hintabout where to find the command for the git root.
doesn't offer this functionality via the CLI, purely because it's not under the
logical
root
command or cross-referenced in its help text. They would need to knowto look under the
jj git
subcommand.I think that either jj root should be removed, or it should grow the ability to print
git roots too.
Beta Was this translation helpful? Give feedback.
All reactions