You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was poking around the any constraints and noticed that Concat looks like it's possibly implemented incorrectly. As you can see schema is declared twice.
/** * Returns a new type that is the result of adding the rules of one type to another. */exportfunctionConcat(schema : Schema) : PropertyDecorator{returnconstraintDecorator([],(schema : Schema)=>{returnschema.concat(schema);});}
I suspect this should be:
/** * Returns a new type that is the result of adding the rules of one type to another. */exportfunctionConcat(schema : Schema) : PropertyDecorator{returnconstraintDecorator([],(existingSchema : Schema)=>{returnexistingSchema.concat(schema);});}
Empty seems to be the same:
/** * Outputs the original untouched value instead of the casted value. */exportfunctionEmpty(schema : any) : PropertyDecorator{returnconstraintDecorator([],(schema : Schema)=>{returnschema.empty(schema);});}
@laurence-myers if you agree I'm happy to create a PR with the fix.
The text was updated successfully, but these errors were encountered:
I was poking around the any constraints and noticed that
Concat
looks like it's possibly implemented incorrectly. As you can seeschema
is declared twice.I suspect this should be:
Empty seems to be the same:
@laurence-myers if you agree I'm happy to create a PR with the fix.
The text was updated successfully, but these errors were encountered: