Skip to content

Commit 0d2b2e1

Browse files
jorisvManifoldFR
andauthored
cmake: Improve CMake comments
Co-authored-by: Wilson <[email protected]>
1 parent fbc81a2 commit 0d2b2e1

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

bindings/python/CMakeLists.txt

+4-3
Original file line numberDiff line numberDiff line change
@@ -161,9 +161,10 @@ if(BUILD_PYTHON_INTERFACE)
161161
set(PINOCCHIO_PYTHON_INSTALL_DIR ${ABSOLUTE_PYTHON_SITELIB}/${PROJECT_NAME})
162162

163163
pinocchio_python_bindings_specific_type(default)
164-
# Precompile Headers are used to speed up compilation of bindings. Tests were performed also on
165-
# pinocchio_default, and there was no gain in using pch for the main lib, compared to the gain for
166-
# bindings. PCH are used to precompile headers of other scalar types as well.
164+
# Precompiled headers are used to speed up compilation of the Python bindings. We have also tested
165+
# precompiling headers for the main library's `pinocchio_default` target, but the time gain there was
166+
# negligible compared to the time gained in the Python bindings.
167+
# We also precompile headers for other scalar types as well.
167168
target_precompile_headers(${PYWRAP}_default PRIVATE
168169
${PROJECT_SOURCE_DIR}/include/pinocchio/bindings/python/pch.hpp)
169170
set(PYTHON_LIB_NAME "${PYWRAP}_default")

0 commit comments

Comments
 (0)