Large file limits for linting

Author: pfitzseb

src/StaticLint.jl

@@ -17,6 +17,8 @@ include("scope.jl")
 include("subtypes.jl")
 include("methodmatching.jl")
 
+const LARGE_FILE_LIMIT = 1_000_000 # bytes
+
 mutable struct Meta
     binding::Union{Nothing,Binding}
     scope::Union{Nothing,Scope}
@@ -277,8 +279,13 @@ function followinclude(x, state::State)
                 seterror!(x, IncludeLoop)
                 return
             end
+            f = getfile(state.server, path)
+            if f.cst.fullspan > LARGE_FILE_LIMIT
+                seterror!(x, FileTooBig)
+                return
+            end
             oldfile = state.file
-            state.file = getfile(state.server, path)
+            state.file = f
             push!(state.included_files, getpath(state.file))
             setroot(state.file, getroot(oldfile))
             setscope!(getcst(state.file), nothing)

src/linting/checks.jl

@@ -27,9 +27,8 @@ UnsupportedConstLocalVariable,
 UnassignedKeywordArgument,
 CannotDefineFuncAlreadyHasValue,
 DuplicateFuncArgName,
-IncludePathContainsNULL)
-
-
+IncludePathContainsNULL,
+FileTooBig)
 
 const LintCodeDescriptions = Dict{LintCodes,String}(IncorrectCallArgs => "Possible method call error.",
     IncorrectIterSpec => "A loop iterator has been used that will likely error.",
@@ -58,7 +57,8 @@ const LintCodeDescriptions = Dict{LintCodes,String}(IncorrectCallArgs => "Possib
     UnassignedKeywordArgument => "Keyword argument not assigned.",
     CannotDefineFuncAlreadyHasValue => "Cannot define function ; it already has a value.",
     DuplicateFuncArgName => "Function argument name not unique.",
-    IncludePathContainsNULL => "Cannot include file, path cotains NULL characters."
+    IncludePathContainsNULL => "Cannot include file, path cotains NULL characters.",
+    FileTooBig => "File too big, not following include."
     )
 
 haserror(m::Meta) = m.error !== nothing