Skip to content

Commit 1cb0224

Browse files
committed
Upgrade node to v18.16 and update tests following the ICU change
The ICU changes come from nodejs/node#46646 in node v18.15.
1 parent cef3308 commit 1cb0224

File tree

5 files changed

+17
-19
lines changed

5 files changed

+17
-19
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ version: 2.1
33
executors:
44
node:
55
docker:
6-
- image: cimg/node:18.14
6+
- image: cimg/node:18.16
77
base:
88
docker:
99
- image: cimg/base:stable

appveyor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
clone_depth: 5
22
environment:
3-
nodejs_version: "18.14"
3+
nodejs_version: "18.16"
44
platform: x64 # flow needs 64b platforms
55

66
branches:

src/test/components/WindowTitle.test.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ describe('WindowTitle', () => {
3535
);
3636

3737
expect(document.title).toBe(
38-
'Firefox – 1/1/1970, 12:00:00\u202FAM UTC – Firefox Profiler'
38+
'Firefox – 1/1/1970, 12:00:00 AM UTC – Firefox Profiler'
3939
);
4040
});
4141

@@ -56,7 +56,7 @@ describe('WindowTitle', () => {
5656
);
5757

5858
expect(document.title).toBe(
59-
'Firefox – macOS 10.14 – 1/1/1970, 12:00:00\u202FAM UTC – Firefox Profiler'
59+
'Firefox – macOS 10.14 – 1/1/1970, 12:00:00 AM UTC – Firefox Profiler'
6060
);
6161
});
6262

@@ -100,9 +100,7 @@ describe('WindowTitle', () => {
100100
</Provider>
101101
);
102102

103-
expect(document.title).toBe(
104-
'1/1/1970, 12:00:00\u202FAM UTC – Firefox Profiler'
105-
);
103+
expect(document.title).toBe('1/1/1970, 12:00:00 AM UTC – Firefox Profiler');
106104
});
107105

108106
it('shows the correct title for uploaded recordings', () => {
@@ -169,7 +167,7 @@ describe('WindowTitle', () => {
169167
);
170168

171169
expect(document.title).toBe(
172-
'bar/profile1.json – Firefox – 1/1/1970, 12:00:00\u202FAM UTC – Firefox Profiler'
170+
'bar/profile1.json – Firefox – 1/1/1970, 12:00:00 AM UTC – Firefox Profiler'
173171
);
174172
});
175173
});

src/test/components/__snapshots__/ListOfPublishedProfiles.test.js.snap

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ exports[`ListOfPublishedProfiles limits the number of rendered profiles with the
6161
<div
6262
class="publishedProfilesDate"
6363
>
64-
2:00PM
64+
2:00 PM
6565
</div>
6666
<div
6767
class="publishedProfilesInfo"
@@ -104,7 +104,7 @@ exports[`ListOfPublishedProfiles limits the number of rendered profiles with the
104104
<div
105105
class="publishedProfilesDate"
106106
>
107-
1:00PM
107+
1:00 PM
108108
</div>
109109
<div
110110
class="publishedProfilesInfo"
@@ -304,7 +304,7 @@ exports[`ListOfPublishedProfiles renders action buttons when appropriate 1`] = `
304304
<div
305305
class="publishedProfilesDate"
306306
>
307-
2:00PM
307+
2:00 PM
308308
</div>
309309
<div
310310
class="publishedProfilesInfo"
@@ -363,7 +363,7 @@ exports[`ListOfPublishedProfiles renders action buttons when appropriate 1`] = `
363363
<div
364364
class="publishedProfilesDate"
365365
>
366-
1:00PM
366+
1:00 PM
367367
</div>
368368
<div
369369
class="publishedProfilesInfo"
@@ -420,7 +420,7 @@ exports[`ListOfPublishedProfiles renders action buttons when appropriate 1`] = `
420420
<div
421421
class="publishedProfilesDate"
422422
>
423-
Jul 3, 8:00AM
423+
Jul 3, 8:00 AM
424424
</div>
425425
<div
426426
class="publishedProfilesInfo"
@@ -543,7 +543,7 @@ exports[`ListOfPublishedProfiles still displays the link to all recordings when
543543
<div
544544
class="publishedProfilesDate"
545545
>
546-
2:00PM
546+
2:00 PM
547547
</div>
548548
<div
549549
class="publishedProfilesInfo"
@@ -586,7 +586,7 @@ exports[`ListOfPublishedProfiles still displays the link to all recordings when
586586
<div
587587
class="publishedProfilesDate"
588588
>
589-
Jul 3, 8:00AM
589+
Jul 3, 8:00 AM
590590
</div>
591591
<div
592592
class="publishedProfilesInfo"
@@ -692,7 +692,7 @@ exports[`ListOfPublishedProfiles still displays the link to all recordings when
692692
<div
693693
class="publishedProfilesDate"
694694
>
695-
2:00PM
695+
2:00 PM
696696
</div>
697697
<div
698698
class="publishedProfilesInfo"

src/test/components/__snapshots__/UploadedRecordingsHome.test.js.snap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ exports[`UploadedRecordingsHome matches a snapshot when rendering published prof
123123
<div
124124
class="publishedProfilesDate"
125125
>
126-
2:00PM
126+
2:00 PM
127127
</div>
128128
<div
129129
class="publishedProfilesInfo"
@@ -182,7 +182,7 @@ exports[`UploadedRecordingsHome matches a snapshot when rendering published prof
182182
<div
183183
class="publishedProfilesDate"
184184
>
185-
1:00PM
185+
1:00 PM
186186
</div>
187187
<div
188188
class="publishedProfilesInfo"
@@ -239,7 +239,7 @@ exports[`UploadedRecordingsHome matches a snapshot when rendering published prof
239239
<div
240240
class="publishedProfilesDate"
241241
>
242-
Jul 3, 8:00AM
242+
Jul 3, 8:00 AM
243243
</div>
244244
<div
245245
class="publishedProfilesInfo"

0 commit comments

Comments
 (0)