Skip to content

Commit 8f4e7cc

Browse files
another-rexoliverchang
authored andcommitted
Make OSV api public (google#167)
* Make OSV api public * Add osv file * Add commend on public function * Removed v1, made maxQueriesPerRequest private * Fix bug --------- Co-authored-by: Oliver Chang <[email protected]>
1 parent ab526b3 commit 8f4e7cc

File tree

5 files changed

+8
-7
lines changed

5 files changed

+8
-7
lines changed

internal/output/table.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import (
66
"path/filepath"
77
"strings"
88

9-
"github.com/google/osv-scanner/internal/osv"
109
"github.com/google/osv-scanner/pkg/models"
10+
"github.com/google/osv-scanner/pkg/osv"
1111

1212
"github.com/jedib0t/go-pretty/v6/table"
1313
"github.com/jedib0t/go-pretty/v6/text"

internal/osv/osv.go renamed to pkg/osv/osv.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ const (
1919
GetEndpoint = "https://api.osv.dev/v1/vulns"
2020
// BaseVulnerabilityURL is the base URL for detailed vulnerability views.
2121
BaseVulnerabilityURL = "https://osv.dev/"
22-
// MaxQueriesPerRequest splits up querybatch into multiple requests if
22+
// maxQueriesPerRequest splits up querybatch into multiple requests if
2323
// number of queries exceed this number
24-
MaxQueriesPerRequest = 1000
24+
maxQueriesPerRequest = 1000
2525
)
2626

2727
// Package represents a package identifier for OSV.
@@ -121,9 +121,10 @@ func checkResponseError(resp *http.Response) error {
121121
return fmt.Errorf("server response error: %s", string(respBuf))
122122
}
123123

124+
// MakeRequest sends a batched query to osv.dev
124125
func MakeRequest(request BatchedQuery) (*BatchedResponse, error) {
125126
// API has a limit of 1000 bulk query per request
126-
queryChunks := chunkBy(request.Queries, MaxQueriesPerRequest)
127+
queryChunks := chunkBy(request.Queries, maxQueriesPerRequest)
127128
var totalOsvResp BatchedResponse
128129
for _, queries := range queryChunks {
129130
requestBytes, err := json.Marshal(BatchedQuery{Queries: queries})

pkg/osvscanner/osvscanner.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@ import (
1010
"path/filepath"
1111
"strings"
1212

13-
"github.com/google/osv-scanner/internal/osv"
1413
"github.com/google/osv-scanner/internal/output"
1514
"github.com/google/osv-scanner/internal/sbom"
1615
"github.com/google/osv-scanner/pkg/config"
1716
"github.com/google/osv-scanner/pkg/lockfile"
1817
"github.com/google/osv-scanner/pkg/models"
18+
"github.com/google/osv-scanner/pkg/osv"
1919
)
2020

2121
type ScannerActions struct {

pkg/osvscanner/vulnerability_result.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ package osvscanner
33
import (
44
"fmt"
55

6-
"github.com/google/osv-scanner/internal/osv"
76
"github.com/google/osv-scanner/internal/output"
87
"github.com/google/osv-scanner/pkg/grouper"
98
"github.com/google/osv-scanner/pkg/models"
9+
"github.com/google/osv-scanner/pkg/osv"
1010
)
1111

1212
// groupResponseBySource converts raw OSV API response into structured vulnerability information

pkg/osvscanner/vulnerability_result_internal_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ import (
44
"reflect"
55
"testing"
66

7-
"github.com/google/osv-scanner/internal/osv"
87
"github.com/google/osv-scanner/internal/output"
98
"github.com/google/osv-scanner/pkg/models"
9+
"github.com/google/osv-scanner/pkg/osv"
1010
)
1111

1212
func Test_groupResponseBySource(t *testing.T) {

0 commit comments

Comments
 (0)