Skip to content

Commit cf08bb7

Browse files
committed
Fix NPE when deserializing TestIdentifier
Issue: #3819
1 parent 5b13209 commit cf08bb7

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

documentation/src/docs/asciidoc/release-notes/release-notes-5.11.0-M2.adoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ repository on GitHub.
2626
[[release-notes-5.11.0-M2-junit-platform-bug-fixes]]
2727
==== Bug Fixes
2828

29+
* Fixed a bug where `TestIdentifier` could cause a `NullPointerException` on deserialize when there is no parent identifier. See link:https://github.com/junit-team/junit5/issues/3819[issue 3819].
2930
* ❓
3031

3132
[[release-notes-5.11.0-M2-junit-platform-deprecations-and-breaking-changes]]

junit-platform-launcher/src/main/java/org/junit/platform/launcher/TestIdentifier.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,8 @@ private static class SerializedForm implements Serializable {
307307

308308
SerializedForm(TestIdentifier testIdentifier) {
309309
this.uniqueId = testIdentifier.uniqueId.toString();
310-
this.parentId = testIdentifier.parentId.toString();
310+
UniqueId parentId = testIdentifier.parentId;
311+
this.parentId = parentId == null ? null : parentId.toString();
311312
this.displayName = testIdentifier.displayName;
312313
this.legacyReportingName = testIdentifier.legacyReportingName;
313314
this.source = testIdentifier.source;

0 commit comments

Comments
 (0)