-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration Parameters Overview #4330
Comments
IMHO, It's very good idea 👍 |
I second that! Ideally, we should generate a machine-readable format from our code that can be used to generate the User Guide appendix and included in the JAR so IDEs don't have to hard-code the allowed keys. @scordio Do you know how this is implemented in IntelliJ IDEA for Spring? |
FYI: this is a duplicate of So, we should only keep one of the issues. Normally we'd close the newer (duplicate) one, but we could also keep this issue since it has a bit more information. |
Spring Boot has a specific metadata format (JSON file included in JAR) that IDEs read. That gets auto-generated based on They look something like this. {"properties": [
{
"name": "my.messaging.addresses",
"defaultValue": ["a", "b"]
},
{
"name": "my.messaging.container-type",
"defaultValue": "simple"
}
]} There is no such metadata format for configuration properties (Spring properties) supported directly by the Spring Framework, so I documented them manually here. As a side note, the documentation for the Common Application Properties for Spring Boot that @scordio linked to is generated from those JSON files in JARs on the classpath for the Spring Boot build. |
Someone in the Spring engineering team mentioned that they think IntelliJ IDEA originally read those JSON files but that IDEA now has its own built-in support for processing So, it's worth confirming with the IDEA team whether they even support those Spring Boot JSON files anymore. |
Sorry, @sbrannen! I should have searched better...
No, I'm not aware of the IDEA implementation. As @sbrannen mentioned, I would also suggest to get in touch with the IDEA team and understand if there is some sort of contract, not necessarily restricted to Spring Boot, that libraries and frameworks can leverage. Would you like me to do it, or would you prefer a JUnit team member doing it? |
Please go ahead or let me know whether I should take care of it. 👍 |
The user guide mentions several configuration parameters for the Jupiter Test Engine. However, they are a bit scattered throughout the chapters.
What do you think about adding an overview to the appendix, in the style of the Spring Boot Common Application Properties?
In addition to the user guide benefit, I would like to ask JetBrains if they are open to support code completion in
junit-platform.properties
files. Having such an overview in the docs might help with that request.Related Issues
Deliverables
The text was updated successfully, but these errors were encountered: