Skip to content

Inconsistent documentation for injectArguments element in BeforeParameterizedClassInvocation annotation #4478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
BlueIce opened this issue Apr 12, 2025 · 3 comments

Comments

@BlueIce
Copy link

BlueIce commented Apr 12, 2025

The documentation for injectArguments element in BeforeParameterizedClassInvocation annotation seems to be inconsistent.

The documentation states that the default value is false.
Looking at the code, the default value seems to be true.

/**
* Whether the arguments of the parameterized test class should be injected
* into the annotated method (defaults to {@code false}).
*/
boolean injectArguments() default true;

Context

  • Used versions (Jupiter/Vintage/Platform): -
  • Build Tool/IDE: -

Deliverables

  • Fix Javadoc
@marcphilipp
Copy link
Member

Thank you for bringing this to my attention! The default was initially false when I introduced it and I forgot to adjust this admittedly pretty obvious place in the docs.

@marcphilipp
Copy link
Member

@BlueIce I pushed a fix. Do you have any other feedback on @ParameterizedClass?

@BlueIce
Copy link
Author

BlueIce commented Apr 21, 2025

@marcphilipp The parameterized classes feature looks really nice.
I like that records can be used, which gives a really compact notation. It would be great if records could also be used as nested parameterized classes, but I guess that's not possible because they are implicit static.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants