Skip to content

Commit 1248890

Browse files
committed
API changes affecting tests
1 parent d2150f4 commit 1248890

File tree

4 files changed

+12
-19
lines changed

4 files changed

+12
-19
lines changed

ipydatagrid/datagrid.py

-7
Original file line numberDiff line numberDiff line change
@@ -1006,13 +1006,6 @@ def __init__(self, *args, debounce_delay=160, **kwargs):
10061006

10071007
self.on_msg(self._handle_comm_msg)
10081008

1009-
def transform(self, _):
1010-
# TODO Implement sorting and filtering backend-side?
1011-
raise RuntimeError(
1012-
"Setting filters and sorting rules to a "
1013-
"StreamingDataGrid is not supported."
1014-
)
1015-
10161009
@property
10171010
def data(self):
10181011
return super().data

tests/js/arrayUtils.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ describe('Test multi index array utilities', () => {
5151
);
5252

5353
// Creating a model
54-
const testModel = new ViewBasedJSONModel(testData.data);
54+
const testModel = new ViewBasedJSONModel({ datasource: testData.data });
5555
// Generating an array with location of nested level headers
5656
const mutltiIndexArrayLocations =
5757
ArrayUtils.generateMultiIndexArrayLocations(testModel);

tests/js/filterMenu.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ namespace Private {
181181
export function createSimpleModel(
182182
data: DataGenerator.ISingleColOptions,
183183
): ViewBasedJSONModel {
184-
const model = new ViewBasedJSONModel(DataGenerator.singleCol(data).data);
184+
const model = new ViewBasedJSONModel({ datasource: DataGenerator.singleCol(data).data });
185185
return model;
186186
}
187187

tests/js/viewbasedjsonmodel.test.ts

+10-10
Original file line numberDiff line numberDiff line change
@@ -133,31 +133,31 @@ describe('Test .uniqueValues()', () => {
133133
{ name: 'col3', type: 'number', data: [100, 200, 100, 300, 200] },
134134
],
135135
});
136-
const testModel = new ViewBasedJSONModel(testData.data);
137-
test('cellregion-column-header-0', () => {
138-
expect(testModel.uniqueValues('column-header', 'col1')).toEqual([
136+
const testModel = new ViewBasedJSONModel({ datasource: testData.data });
137+
test('cellregion-column-header-0', async () => {
138+
expect(await testModel.uniqueValues('column-header', 'col1')).toEqual([
139139
10,
140140
20,
141141
30,
142142
40,
143143
50,
144144
]);
145145
});
146-
test('cellregion-column-header-1', () => {
147-
expect(testModel.uniqueValues('column-header', 'col2')).toEqual([
146+
test('cellregion-column-header-1', async () => {
147+
expect(await testModel.uniqueValues('column-header', 'col2')).toEqual([
148148
true,
149149
false,
150150
]);
151151
});
152-
test('cellregion-column-header-2', () => {
153-
expect(testModel.uniqueValues('column-header', 'col3')).toEqual([
152+
test('cellregion-column-header-2', async () => {
153+
expect(await testModel.uniqueValues('column-header', 'col3')).toEqual([
154154
100,
155155
200,
156156
300,
157157
]);
158158
});
159-
test('cellregion-corner-header-0', () => {
160-
expect(testModel.uniqueValues('corner-header', 'index')).toEqual([
159+
test('cellregion-corner-header-0', async () => {
160+
expect(await testModel.uniqueValues('corner-header', 'index')).toEqual([
161161
'A',
162162
'C',
163163
'B',
@@ -172,7 +172,7 @@ namespace Private {
172172
type: 'number',
173173
data: [1, 2, 3, 4],
174174
});
175-
const model = new ViewBasedJSONModel(testData.data);
175+
const model = new ViewBasedJSONModel({ datasource: testData.data });
176176
return model;
177177
}
178178
}

0 commit comments

Comments
 (0)