fix: recovery events logging fix for onboarding #2830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagarnaikjuspay
added
S-waiting-on-review
|
Review changes with |
|
don't merge, will review events |
susrithasabbini
approved these changes
Apr 16, 2025
JeevaRamu0104
approved these changes
Apr 22, 2025
|
We need to change the terminology here, don't merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
recovery onboarding triggering mixpanel event on every step which before some steps had not logging events
Motivation and Context
How did you test it?
the every next button click on recovery onboarding should trigger a mixpanel logging event
Where to test it?
Checklist
npm run re:build