Skip to content

Commit fd443a2

Browse files
arndbbroonie
authored andcommitted
ASoC: rt5682: fix I2C/Soundwire dependencies
If one of the two is a loadable module, the combined driver must not be built-in: aarch64-linux-ld: sound/soc/codecs/rt5682.o: in function `rt5682_sdw_hw_free': rt5682.c:(.text+0xb34): undefined reference to `sdw_stream_remove_slave' aarch64-linux-ld: sound/soc/codecs/rt5682.o: in function `rt5682_sdw_hw_params': rt5682.c:(.text+0xe78): undefined reference to `sdw_stream_add_slave' In particular, the soundwire driver must not be built-in if CONFIG_I2C=m. Fixes: 5549ea6 ("ASoC: rt5682: fix unmet dependencies") Signed-off-by: Arnd Bergmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 087e390 commit fd443a2

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

sound/soc/codecs/Kconfig

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1137,10 +1137,13 @@ config SND_SOC_RT5677_SPI
11371137
config SND_SOC_RT5682
11381138
tristate
11391139
depends on I2C || SOUNDWIRE
1140+
depends on SOUNDWIRE || !SOUNDWIRE
1141+
depends on I2C || !I2C
11401142

11411143
config SND_SOC_RT5682_SDW
11421144
tristate "Realtek RT5682 Codec - SDW"
11431145
depends on SOUNDWIRE
1146+
depends on I2C || !I2C
11441147
select SND_SOC_RT5682
11451148
select REGMAP_SOUNDWIRE
11461149

0 commit comments

Comments
 (0)