Skip to content

Commit 9ba0263

Browse files
Andreas GruenbacherTrond Myklebust
authored andcommitted
[PATCH] RPC: Allow the sunrpc server to multiplex serveral programs on a single port
The NFS and NFSACL programs run on the same RPC transport. This patch adds support for this by converting svc_program into a chained list of programs (server-side). Signed-off-by: Andreas Gruenbacher <[email protected]> Signed-off-by: Olaf Kirch <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Trond Myklebust <[email protected]>
1 parent a838cc4 commit 9ba0263

File tree

2 files changed

+20
-18
lines changed

2 files changed

+20
-18
lines changed

include/linux/sunrpc/svc.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,9 +240,10 @@ struct svc_deferred_req {
240240
};
241241

242242
/*
243-
* RPC program
243+
* List of RPC programs on the same transport endpoint
244244
*/
245245
struct svc_program {
246+
struct svc_program * pg_next; /* other programs (same xprt) */
246247
u32 pg_prog; /* program number */
247248
unsigned int pg_lovers; /* lowest version */
248249
unsigned int pg_hivers; /* lowest version */

net/sunrpc/svc.c

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -35,29 +35,31 @@ svc_create(struct svc_program *prog, unsigned int bufsize)
3535
if (!(serv = (struct svc_serv *) kmalloc(sizeof(*serv), GFP_KERNEL)))
3636
return NULL;
3737
memset(serv, 0, sizeof(*serv));
38+
serv->sv_name = prog->pg_name;
3839
serv->sv_program = prog;
3940
serv->sv_nrthreads = 1;
4041
serv->sv_stats = prog->pg_stats;
4142
serv->sv_bufsz = bufsize? bufsize : 4096;
42-
prog->pg_lovers = prog->pg_nvers-1;
4343
xdrsize = 0;
44-
for (vers=0; vers<prog->pg_nvers ; vers++)
45-
if (prog->pg_vers[vers]) {
46-
prog->pg_hivers = vers;
47-
if (prog->pg_lovers > vers)
48-
prog->pg_lovers = vers;
49-
if (prog->pg_vers[vers]->vs_xdrsize > xdrsize)
50-
xdrsize = prog->pg_vers[vers]->vs_xdrsize;
51-
}
44+
while (prog) {
45+
prog->pg_lovers = prog->pg_nvers-1;
46+
for (vers=0; vers<prog->pg_nvers ; vers++)
47+
if (prog->pg_vers[vers]) {
48+
prog->pg_hivers = vers;
49+
if (prog->pg_lovers > vers)
50+
prog->pg_lovers = vers;
51+
if (prog->pg_vers[vers]->vs_xdrsize > xdrsize)
52+
xdrsize = prog->pg_vers[vers]->vs_xdrsize;
53+
}
54+
prog = prog->pg_next;
55+
}
5256
serv->sv_xdrsize = xdrsize;
5357
INIT_LIST_HEAD(&serv->sv_threads);
5458
INIT_LIST_HEAD(&serv->sv_sockets);
5559
INIT_LIST_HEAD(&serv->sv_tempsocks);
5660
INIT_LIST_HEAD(&serv->sv_permsocks);
5761
spin_lock_init(&serv->sv_lock);
5862

59-
serv->sv_name = prog->pg_name;
60-
6163
/* Remove any stale portmap registrations */
6264
svc_register(serv, 0, 0);
6365

@@ -339,7 +341,10 @@ svc_process(struct svc_serv *serv, struct svc_rqst *rqstp)
339341
goto sendit;
340342
}
341343

342-
if (prog != progp->pg_prog)
344+
for (progp = serv->sv_program; progp; progp = progp->pg_next)
345+
if (prog == progp->pg_prog)
346+
break;
347+
if (progp == NULL)
343348
goto err_bad_prog;
344349

345350
if (vers >= progp->pg_nvers ||
@@ -452,11 +457,7 @@ svc_process(struct svc_serv *serv, struct svc_rqst *rqstp)
452457
goto sendit;
453458

454459
err_bad_prog:
455-
#ifdef RPC_PARANOIA
456-
if (prog != 100227 || progp->pg_prog != 100003)
457-
printk("svc: unknown program %d (me %d)\n", prog, progp->pg_prog);
458-
/* else it is just a Solaris client seeing if ACLs are supported */
459-
#endif
460+
dprintk("svc: unknown program %d\n", prog);
460461
serv->sv_stats->rpcbadfmt++;
461462
svc_putu32(resv, rpc_prog_unavail);
462463
goto sendit;

0 commit comments

Comments
 (0)