btrfs: warn for num_devices below 0

asj · asj · commit dd61850ee7cf · 2018-07-11T17:05:17.000+08:00
In preparation to de-duplicate a section of code where we deduce the
num_devices, use warn instead of bug.

Signed-off-by: Anand Jain &lt;anand.jain@oracle.com&gt;
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
@@ -3728,7 +3728,7 @@ int btrfs_balance(struct btrfs_fs_info *fs_info,
 	num_devices = fs_info->fs_devices->num_devices;
 	btrfs_dev_replace_read_lock(&fs_info->dev_replace);
 	if (btrfs_dev_replace_is_ongoing(&fs_info->dev_replace)) {
-		BUG_ON(num_devices < 1);
+		WARN_ON(num_devices < 1);
 		num_devices--;
 	}
 	btrfs_dev_replace_read_unlock(&fs_info->dev_replace);

Original file line number	Diff line number	Diff line change
`@@ -3728,7 +3728,7 @@ int btrfs_balance(struct btrfs_fs_info *fs_info,`
`3728`	`3728`	`num_devices = fs_info->fs_devices->num_devices;`
`3729`	`3729`	`btrfs_dev_replace_read_lock(&fs_info->dev_replace);`
`3730`	`3730`	`if (btrfs_dev_replace_is_ongoing(&fs_info->dev_replace)) {`
`3731`		`- BUG_ON(num_devices < 1);`
	`3731`	`+ WARN_ON(num_devices < 1);`
`3732`	`3732`	`num_devices--;`
`3733`	`3733`	`}`
`3734`	`3734`	`btrfs_dev_replace_read_unlock(&fs_info->dev_replace);`