Skip to content

Commit 5eb7683

Browse files
committed
chore: removing unused metricsCfg references
Signed-off-by: Joe Wogan <[email protected]>
1 parent 0578ef2 commit 5eb7683

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

interceptor/metrics/metricscollector.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ func NewMetricsCollectors(metricsConfig *config.Metrics) {
2222
}
2323

2424
if metricsConfig.OtelHTTPExporterEnabled {
25-
otelhttpmetrics := NewOtelMetrics(metricsConfig)
25+
otelhttpmetrics := NewOtelMetrics()
2626
collectors = append(collectors, otelhttpmetrics)
2727
}
2828
}

interceptor/metrics/otelmetrics.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import (
1111
"go.opentelemetry.io/otel/sdk/resource"
1212
semconv "go.opentelemetry.io/otel/semconv/v1.4.0"
1313

14-
"github.com/kedacore/http-add-on/interceptor/config"
1514
"github.com/kedacore/http-add-on/pkg/build"
1615
)
1716

@@ -21,7 +20,7 @@ type OtelMetrics struct {
2120
pendingRequestCounter api.Int64UpDownCounter
2221
}
2322

24-
func NewOtelMetrics(metricsConfig *config.Metrics, options ...metric.Option) *OtelMetrics {
23+
func NewOtelMetrics(options ...metric.Option) *OtelMetrics {
2524
ctx := context.Background()
2625

2726
exporter, err := otlpmetrichttp.New(ctx)

interceptor/metrics/otelmetrics_test.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import (
77
"github.com/stretchr/testify/assert"
88
"go.opentelemetry.io/otel/sdk/metric"
99
"go.opentelemetry.io/otel/sdk/metric/metricdata"
10-
11-
"github.com/kedacore/http-add-on/interceptor/config"
1210
)
1311

1412
var (
@@ -19,8 +17,7 @@ var (
1917
func init() {
2018
testReader = metric.NewManualReader()
2119
options := metric.WithReader(testReader)
22-
metricsCfg := config.Metrics{}
23-
testOtel = NewOtelMetrics(&metricsCfg, options)
20+
testOtel = NewOtelMetrics(options)
2421
}
2522

2623
func TestRequestCounter(t *testing.T) {

0 commit comments

Comments
 (0)