Skip to content

Revert "Fixes inconsistent serialization logic for inputs (#20993) #21336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2025

Conversation

divyashreepathihalli
Copy link
Collaborator

This is a breaking change

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels May 30, 2025
@fchollet
Copy link
Collaborator

Can you link to the original commit?

@fchollet
Copy link
Collaborator

Found it. LGTM

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.65%. Comparing base (de9cf25) to head (57b3166).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21336      +/-   ##
==========================================
- Coverage   82.65%   82.65%   -0.01%     
==========================================
  Files         565      565              
  Lines       54823    54825       +2     
  Branches     8514     8515       +1     
==========================================
  Hits        45315    45315              
- Misses       7414     7415       +1     
- Partials     2094     2095       +1     
Flag Coverage Δ
keras 82.46% <100.00%> (-0.01%) ⬇️
keras-jax 63.58% <100.00%> (-0.01%) ⬇️
keras-numpy 58.73% <100.00%> (-0.02%) ⬇️
keras-openvino 33.13% <50.00%> (-0.01%) ⬇️
keras-tensorflow 64.00% <100.00%> (-0.01%) ⬇️
keras-torch 63.65% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JyotinderSingh
Copy link
Collaborator

Thanks for the fix!

1 similar comment
@JyotinderSingh
Copy link
Collaborator

Thanks for the fix!

@fchollet fchollet merged commit 802299e into keras-team:master May 31, 2025
11 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants