Skip to content

Avoid one IP to take all the connections of the pool #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kelson42 opened this issue Nov 13, 2017 · 4 comments · Fixed by kiwix/libkiwix#700 or #534
Closed

Avoid one IP to take all the connections of the pool #106

kelson42 opened this issue Nov 13, 2017 · 4 comments · Fixed by kiwix/libkiwix#700 or #534
Assignees
@juuz0
Labels
enhancement good first issue kiwix-serve
Milestone
3.3.0

Comments

@kelson42
Copy link
Contributor

libmicrohttps proposes To avoid one MHD_OPTION_PER_IP_CONNECTION_LIMIT which seems to be adapted to that.
@kelson42 kelson42 changed the title Avoid one IP to take all the connection Avoid one IP to take all the connections of the pool Feb 10, 2018
@kelson42 kelson42 self-assigned this Jul 29, 2019
@kelson42 kelson42 mentioned this issue Jan 10, 2020
Closed
@kelson42
Copy link
Contributor Author

kelson42 commented Jan 9, 2021

I believe it should be 6. See https://docs.pushtechnology.com/cloud/latest/manual/html/designguide/solution/support/connection_limitations.html

@kelson42
Copy link
Contributor Author

kelson42 commented Feb 3, 2022 •
edited
Loading

@juuz0 Do you think you could implement this please? infinite (undefined) should be the default value, but it would be good to implement an option to allow to change it: --maxConnectionsPerIP

@kelson42 kelson42 added this to the 3.3.0 milestone Feb 3, 2022
@juuz0
Copy link
Collaborator

juuz0 commented Feb 3, 2022

@kelson42 Thanks, I'll look into it. You can assign me :)

@kelson42 kelson42 pinned this issue Feb 3, 2022
This was referenced Feb 5, 2022
Merged
Merged
@kelson42
Copy link
Contributor Author

kelson42 commented Feb 6, 2022

See my email to the microhttpd mailinglist at https://lists.gnu.org/archive/html/libmicrohttpd/2022-02/index.html

@kelson42 kelson42 removed their assignment Feb 6, 2022
@kelson42 kelson42 unpinned this issue Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juuz0 juuz0

Labels
enhancement good first issue kiwix-serve
Projects
None yet
Milestone
3.3.0
2 participants
@kelson42 @juuz0