Skip to content

Multiple problems around CI/CD #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kelson42 opened this issue Jul 26, 2023 · 3 comments · Fixed by #983
Closed

Multiple problems around CI/CD #982

kelson42 opened this issue Jul 26, 2023 · 3 comments · Fixed by #983
Assignees
Labels
Milestone

Comments

@kelson42
Copy link
Collaborator

  • 12.1.0 as not been published on PPA
  • Not using the release trigger
  • Debian packages are not tested in the CI (and probably don't pass)
  • Unable to compile anyway on Debian unstable because of
  • CI not using latest base image
  • ....
@kelson42 kelson42 added the bug label Jul 26, 2023
@kelson42 kelson42 self-assigned this Jul 26, 2023
@mgautierfr
Copy link
Member

12.1.0 as not been published on PPA

It seems that the root cause is this PR #895 which filter the trigger on push on main only (and so, not running the CI on tag push)

Debian packages are not tested in the CI (and probably don't pass)

They are. See all workflow runs in https://github.com/kiwix/libkiwix/actions/workflows/package.yml

Although, the publication of the package is done only on main and it fails for kinetic. I don't why it fails (and why I don't have notification for them).
But building the package is run on all PR.

Unable to compile anyway on Debian unstable because of

#877

@kelson42
Copy link
Collaborator Author

Debian packages are not tested in the CI (and probably don't pass)

They are. See all workflow runs in https://github.com/kiwix/libkiwix/actions/workflows/package.yml

They are not, I guess you are mixing deb files for Ubuntu and deb files for Debian.

@mgautierfr
Copy link
Member

They are not, I guess you are mixing deb files for Ubuntu and deb files for Debian.

Indeed.
BTW, this part is a enhancement, not a bug (I'm not saying that we shouldn't do it).

@kelson42 kelson42 added this to the 13.0.0 milestone Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants