fix: Ignore not-found errors

Author: codablock

controllers/gitprojector_controller.go

@@ -72,8 +72,10 @@ func (r *GitProjectorReconciler) Reconcile(ctx context.Context, req ctrl.Request
 	var obj templatesv1alpha1.GitProjector
 	err = r.Get(ctx, req.NamespacedName, &obj)
 	if err != nil {
-		logger.Error(err, "Get failed")
 		err = client.IgnoreNotFound(err)
+		if err != nil {
+			logger.Error(err, "Get failed")
+		}
 		return
 	}
 

controllers/listgithubpullrequests_controller.go

@@ -49,11 +49,15 @@ type ListGithubPullRequestsReconciler struct {
 //+kubebuilder:rbac:groups="",resources=secrets,verbs=get;list;watch
 
 func (r *ListGithubPullRequestsReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
-	_ = log.FromContext(ctx)
+	logger := log.FromContext(ctx)
 
 	var obj templatesv1alpha1.ListGithubPullRequests
 	err := r.Get(ctx, req.NamespacedName, &obj)
 	if err != nil {
+		err = client.IgnoreNotFound(err)
+		if err != nil {
+			logger.Error(err, "Get failed")
+		}
 		return ctrl.Result{}, err
 	}
 

controllers/listgitlabmergerequests_controller.go

@@ -46,11 +46,15 @@ type ListGitlabMergeRequestsReconciler struct {
 //+kubebuilder:rbac:groups="",resources=secrets,verbs=get;list;watch
 
 func (r *ListGitlabMergeRequestsReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
-	_ = log.FromContext(ctx)
+	logger := log.FromContext(ctx)
 
 	var obj templatesv1alpha1.ListGitlabMergeRequests
 	err := r.Get(ctx, req.NamespacedName, &obj)
 	if err != nil {
+		err = client.IgnoreNotFound(err)
+		if err != nil {
+			logger.Error(err, "Get failed")
+		}
 		return ctrl.Result{}, err
 	}
 

controllers/objecttemplate_controller.go

@@ -69,8 +69,10 @@ func (r *ObjectTemplateReconciler) Reconcile(ctx context.Context, req ctrl.Reque
 	var rt templatesv1alpha1.ObjectTemplate
 	err = r.Get(ctx, req.NamespacedName, &rt)
 	if err != nil {
-		logger.Error(err, "Get failed")
 		err = client.IgnoreNotFound(err)
+		if err != nil {
+			logger.Error(err, "Get failed")
+		}
 		return
 	}
 

controllers/texttemplate_controller.go

@@ -59,8 +59,10 @@ func (r *TextTemplateReconciler) Reconcile(ctx context.Context, req ctrl.Request
 	var tt templatesv1alpha1.TextTemplate
 	err = r.Get(ctx, req.NamespacedName, &tt)
 	if err != nil {
-		logger.Error(err, "Get failed")
 		err = client.IgnoreNotFound(err)
+		if err != nil {
+			logger.Error(err, "Get failed")
+		}
 		return
 	}