Skip to content
This repository was archived by the owner on Apr 17, 2024. It is now read-only.

Commit 09f597a

Browse files
author
Deepika Upadhyay
committed
ci: timeout-minutes has a known issue with composite
use timeout for the step in main workflow instead actions/runner#1979 https://github.com/metabase/metabase/pull/24554/files once support for timeout-minutes is added we can remove these steps Signed-off-by: Deepika Upadhyay <[email protected]>
1 parent aeaa53f commit 09f597a

10 files changed

+38
-3
lines changed

.github/workflows/build.yml

+3
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,8 @@ jobs:
6666
run: tests/scripts/validate_modified_files.sh gen-rbac
6767

6868
- name: consider debugging
69+
if: failure()
70+
timeout-minutes: 60
6971
uses: ./.github/workflows/tmate_debug
7072

7173
linux-build-all:
@@ -97,4 +99,5 @@ jobs:
9799
98100
- name: consider debugging
99101
if: failure()
102+
timeout-minutes: 60
100103
uses: ./.github/workflows/tmate_debug

.github/workflows/canary-integration-test.yml

+19
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ jobs:
204204

205205
- name: consider debugging
206206
if: failure() && github.event_name == 'pull_request'
207+
timeout-minutes: 60
207208
uses: ./.github/workflows/tmate_debug
208209

209210
raw-disk:
@@ -255,6 +256,7 @@ jobs:
255256

256257
- name: consider debugging
257258
if: failure() && github.event_name == 'pull_request'
259+
timeout-minutes: 60
258260
uses: ./.github/workflows/tmate_debug
259261

260262
two-osds-in-device:
@@ -300,6 +302,7 @@ jobs:
300302

301303
- name: consider debugging
302304
if: failure() && github.event_name == 'pull_request'
305+
timeout-minutes: 60
303306
uses: ./.github/workflows/tmate_debug
304307

305308
osd-with-metadata-device:
@@ -351,6 +354,7 @@ jobs:
351354

352355
- name: consider debugging
353356
if: failure() && github.event_name == 'pull_request'
357+
timeout-minutes: 60
354358
uses: ./.github/workflows/tmate_debug
355359

356360
encryption:
@@ -447,6 +451,7 @@ jobs:
447451

448452
- name: consider debugging
449453
if: failure() && github.event_name == 'pull_request'
454+
timeout-minutes: 60
450455
uses: ./.github/workflows/tmate_debug
451456

452457
pvc:
@@ -518,6 +523,7 @@ jobs:
518523

519524
- name: consider debugging
520525
if: failure() && github.event_name == 'pull_request'
526+
timeout-minutes: 60
521527
uses: ./.github/workflows/tmate_debug
522528

523529
pvc-db:
@@ -565,6 +571,7 @@ jobs:
565571

566572
- name: consider debugging
567573
if: failure() && github.event_name == 'pull_request'
574+
timeout-minutes: 60
568575
uses: ./.github/workflows/tmate_debug
569576

570577
pvc-db-wal:
@@ -615,6 +622,7 @@ jobs:
615622

616623
- name: consider debugging
617624
if: failure() && github.event_name == 'pull_request'
625+
timeout-minutes: 60
618626
uses: ./.github/workflows/tmate_debug
619627

620628
encryption-pvc:
@@ -682,6 +690,7 @@ jobs:
682690

683691
- name: consider debugging
684692
if: failure() && github.event_name == 'pull_request'
693+
timeout-minutes: 60
685694
uses: ./.github/workflows/tmate_debug
686695

687696
encryption-pvc-db:
@@ -731,6 +740,7 @@ jobs:
731740

732741
- name: consider debugging
733742
if: failure() && github.event_name == 'pull_request'
743+
timeout-minutes: 60
734744
uses: ./.github/workflows/tmate_debug
735745

736746
encryption-pvc-db-wal:
@@ -781,6 +791,7 @@ jobs:
781791

782792
- name: consider debugging
783793
if: failure() && github.event_name == 'pull_request'
794+
timeout-minutes: 60
784795
uses: ./.github/workflows/tmate_debug
785796

786797
encryption-pvc-kms-vault-token-auth:
@@ -859,6 +870,7 @@ jobs:
859870

860871
- name: consider debugging
861872
if: failure() && github.event_name == 'pull_request'
873+
timeout-minutes: 60
862874
uses: ./.github/workflows/tmate_debug
863875

864876
encryption-pvc-kms-vault-k8s-auth:
@@ -919,6 +931,7 @@ jobs:
919931

920932
- name: consider debugging
921933
if: failure() && github.event_name == 'pull_request'
934+
timeout-minutes: 60
922935
uses: ./.github/workflows/tmate_debug
923936

924937
lvm-pvc:
@@ -971,6 +984,7 @@ jobs:
971984

972985
- name: consider debugging
973986
if: failure() && github.event_name == 'pull_request'
987+
timeout-minutes: 60
974988
uses: ./.github/workflows/tmate_debug
975989

976990
multi-cluster-mirroring:
@@ -1219,6 +1233,7 @@ jobs:
12191233

12201234
- name: consider debugging
12211235
if: failure() && github.event_name == 'pull_request'
1236+
timeout-minutes: 60
12221237
uses: ./.github/workflows/tmate_debug
12231238

12241239
rgw-multisite-testing:
@@ -1245,6 +1260,7 @@ jobs:
12451260

12461261
- name: consider debugging
12471262
if: failure() && github.event_name == 'pull_request'
1263+
timeout-minutes: 60
12481264
uses: ./.github/workflows/tmate_debug
12491265

12501266
encryption-pvc-kms-ibm-kp:
@@ -1274,6 +1290,7 @@ jobs:
12741290

12751291
- name: consider debugging
12761292
if: failure() && github.event_name == 'pull_request'
1293+
timeout-minutes: 60
12771294
uses: ./.github/workflows/tmate_debug
12781295

12791296
multus-cluster-network:
@@ -1353,6 +1370,7 @@ jobs:
13531370

13541371
- name: consider debugging
13551372
if: failure() && github.event_name == 'pull_request'
1373+
timeout-minutes: 60
13561374
uses: ./.github/workflows/tmate_debug
13571375

13581376
csi-hostnetwork-disabled:
@@ -1403,4 +1421,5 @@ jobs:
14031421

14041422
- name: consider debugging
14051423
if: failure() && github.event_name == 'pull_request'
1424+
timeout-minutes: 60
14061425
uses: ./.github/workflows/tmate_debug

.github/workflows/integration-test-helm-suite.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -63,4 +63,5 @@ jobs:
6363

6464
- name: consider debugging
6565
if: failure() && github.event_name == 'pull_request'
66+
timeout-minutes: 60
6667
uses: ./.github/workflows/tmate_debug

.github/workflows/integration-test-mgr-suite.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -57,4 +57,5 @@ jobs:
5757

5858
- name: consider debugging
5959
if: failure() && github.event_name == 'pull_request'
60+
timeout-minutes: 60
6061
uses: ./.github/workflows/tmate_debug

.github/workflows/integration-test-multi-cluster-suite.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -59,4 +59,5 @@ jobs:
5959

6060
- name: consider debugging
6161
if: failure() && github.event_name == 'pull_request'
62+
timeout-minutes: 60
6263
uses: ./.github/workflows/tmate_debug

.github/workflows/integration-test-object-suite.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -58,4 +58,5 @@ jobs:
5858

5959
- name: consider debugging
6060
if: failure() && github.event_name == 'pull_request'
61+
timeout-minutes: 60
6162
uses: ./.github/workflows/tmate_debug

.github/workflows/integration-test-smoke-suite.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -58,4 +58,5 @@ jobs:
5858

5959
- name: consider debugging
6060
if: failure() && github.event_name == 'pull_request'
61+
timeout-minutes: 60
6162
uses: ./.github/workflows/tmate_debug

.github/workflows/integration-test-upgrade-suite.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -106,4 +106,5 @@ jobs:
106106

107107
- name: consider debugging
108108
if: failure() && github.event_name == 'pull_request'
109+
timeout-minutes: 60
109110
uses: ./.github/workflows/tmate_debug

.github/workflows/push-build.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -78,4 +78,5 @@ jobs:
7878
7979
- name: consider debugging
8080
if: failure()
81+
timeout-minutes: 60
8182
uses: ./.github/workflows/tmate_debug

.github/workflows/tmate_debug/action.yml

+9-3
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,24 @@
11
name: "Tmate debugging tests"
22
description: "Setup tmate session if the test fails"
3+
<<<<<<< HEAD
34
# ...name, description and inputs as above
5+
=======
6+
inputs:
7+
use-tmate:
8+
description: "boolean for enabling TMATE"
9+
required: true
10+
>>>>>>> fef11fa6a (ci: timeout-minutes has a known issue with composite)
411
runs:
512
using: "composite"
613
steps:
714
- name: consider debugging
815
shell: bash --noprofile --norc -eo pipefail -x {0}
9-
if: failure() && github.event_name == 'pull_request'
1016
run: |
1117
# Enable tmate only in the Rook fork, where the USE_TMATE secret is set in the repo, or if the action is re-run
1218
if [ "$GITHUB_REPOSITORY_OWNER" = "koor-tech" ] || [ -n "${{ secrets.USE_TMATE }}" ] || [ "$GITHUB_RUN_ATTEMPT" -gt 1 ]; then
1319
echo USE_TMATE=1 >> $GITHUB_ENV
1420
fi
21+
1522
- name: set up tmate session for debugging
16-
if: failure() && env.USE_TMATE
23+
if: env.USE_TMATE
1724
uses: mxschmitt/action-tmate@v3
18-
timeout-minutes: 60

0 commit comments

Comments
 (0)