Add better exceptions for dotnet type converter (#809)

Author: Ulimo

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/BatchConverter.cs

@@ -237,7 +237,16 @@ public object ConvertToDotNetObject(IReadOnlyList<IColumn> columns, int index)
             for (int i = 0; i < properties.Count; i++)
             {
                 var property = properties[i];
-                var value = converters[i].Deserialize(columns[i].GetValueAt(index, default));
+                object? value = default;
+                try
+                {
+                    value = converters[i].Deserialize(columns[i].GetValueAt(index, default));
+                }
+                catch(Exception e)
+                {
+                    throw new InvalidOperationException($"Could not deserialize property {property.Name}, Check inner exception for type details", e);
+                }
+                
 
                 if (property.SetFunc == null)
                 {

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/ArrayConverter.cs

@@ -53,7 +53,7 @@ public object Deserialize<T>(T value) where T : IDataValue
             }
             else
             {
-                throw new NotImplementedException();
+                throw new NotImplementedException($"Can not deserialize {value.Type} to array");
             }
         }
 

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/BoolConverter.cs

@@ -28,7 +28,7 @@ public object Deserialize<T>(T value) where T : IDataValue
             {
                 return value.AsBool;
             }
-            throw new NotImplementedException();
+            throw new NotImplementedException($"Can not deserialize {value.Type} to string");
         }
 
         public SubstraitBaseType GetSubstraitType()

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/ByteArrayConverter.cs

@@ -27,7 +27,7 @@ public object Deserialize<T>(T value) where T : IDataValue
             {
                 return value.AsBinary.ToArray();
             }
-            throw new NotImplementedException();
+            throw new NotImplementedException($"Can not deserialize {value.Type} to byte array");
         }
 
         public SubstraitBaseType GetSubstraitType()

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/DateTimeConverter.cs

@@ -35,7 +35,7 @@ public object Deserialize<T>(T value) where T : IDataValue
                 return timestamp.ToDateTimeOffset().DateTime;
             }
 
-            throw new NotImplementedException();
+            throw new NotImplementedException($"Can not deserialize {value.Type} to datetime");
         }
 
         public SubstraitBaseType GetSubstraitType()

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/DateTimeOffsetConverter.cs

@@ -28,7 +28,7 @@ public object Deserialize<T>(T value) where T : IDataValue
             {
                 return value.AsTimestamp.ToDateTimeOffset();
             }
-            throw new NotImplementedException();
+            throw new NotImplementedException($"Can not deserialize {value.Type} to datetimeoffset");
         }
 
         public SubstraitBaseType GetSubstraitType()

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/DecimalConverter.cs

@@ -29,7 +29,7 @@ public object Deserialize<T>(T value) where T : IDataValue
                 return value.AsDecimal;
             }
 
-            throw new NotImplementedException();
+            throw new NotImplementedException($"Can not deserialize {value.Type} to decimal");
         }
 
         public SubstraitBaseType GetSubstraitType()

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/DictionaryConverter.cs

@@ -65,7 +65,7 @@ public object Deserialize<T>(T value) where T : IDataValue
                 return dictionary;
             }
 
-            throw new NotImplementedException();
+            throw new NotImplementedException($"Can not deserialize {value.Type} to dictionary");
         }
 
         public SubstraitBaseType GetSubstraitType()

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/DoubleConverter.cs

@@ -28,7 +28,7 @@ public object Deserialize<T>(T value) where T : IDataValue
             {
                 return value.AsDouble;
             }
-            throw new NotImplementedException();
+            throw new NotImplementedException($"Can not deserialize {value.Type} to double");
         }
 
         public SubstraitBaseType GetSubstraitType()

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/EnumConverter.cs

@@ -30,7 +30,7 @@ public object Deserialize<T>(T value) where T : IDataValue
             {
                 return Enum.ToObject(enumType, value.AsLong);
             }
-            throw new NotImplementedException();
+            throw new NotImplementedException($"Can not deserialize {value.Type} to enum");
         }
 
         public SubstraitBaseType GetSubstraitType()

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/EnumStringConverter.cs

@@ -31,7 +31,7 @@ public object Deserialize<T>(T value) where T : IDataValue
             {
                 return Enum.Parse(enumType, value.AsString.ToString());
             }
-            throw new NotImplementedException();
+            throw new NotImplementedException($"Can not deserialize {value.Type} to enum");
         }
 
         public SubstraitBaseType GetSubstraitType()

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/FloatConverter.cs

@@ -29,7 +29,7 @@ public object Deserialize<T>(T value) where T : IDataValue
                 return (float)value.AsDouble;
             }
 
-            throw new NotImplementedException();
+            throw new NotImplementedException($"Can not deserialize {value.Type} to float");
         }
 
         public SubstraitBaseType GetSubstraitType()

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/Int64Converter.cs

@@ -42,7 +42,7 @@ public object Deserialize<T>(T value) where T : IDataValue
             }
             else
             {
-                throw new NotImplementedException();
+                throw new NotImplementedException($"Can not deserialize {value.Type} to int64");
             }
 
         }

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/ListConverter.cs

@@ -48,7 +48,7 @@ public object Deserialize<T>(T value) where T : IDataValue
             }
             else
             {
-                throw new NotImplementedException();
+                throw new NotImplementedException($"Can not deserialize {value.Type} to list");
             }
         }
 

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/MemoryByteConverter.cs

@@ -28,7 +28,7 @@ public object Deserialize<T>(T value) where T : IDataValue
             {
                 return new Memory<byte>(value.AsBinary.ToArray());
             }
-            throw new NotImplementedException();
+            throw new NotImplementedException($"Can not deserialize {value.Type} to Memory<byte>");
         }
 
         public SubstraitBaseType GetSubstraitType()

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/ObjectConverter.cs

@@ -95,7 +95,7 @@ public object Deserialize<T>(T value) where T : IDataValue
             }
             else
             {
-                throw new NotImplementedException();
+                throw new NotImplementedException($"Can not deserialize {value.Type} to generic object");
             }
         }
 

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/ReadOnlyMemoryConverter.cs

@@ -29,7 +29,7 @@ public object Deserialize<T>(T value) where T : IDataValue
                 return new ReadOnlyMemory<byte>(value.AsBinary.ToArray());
             }
 
-            throw new NotImplementedException();
+            throw new NotImplementedException($"Can not deserialize {value.Type} to ReadOnlyMemory");
         }
 
         public SubstraitBaseType GetSubstraitType()

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/StringConverter.cs

@@ -29,7 +29,7 @@ public object Deserialize<T>(T value) where T : IDataValue
             }
             else
             {
-                throw new NotImplementedException();
+                throw new NotImplementedException($"Can not deserialize {value.Type} to string");
             }
         }
 

src/FlowtideDotNet.Core/ColumnStore/ObjectConverter/Converters/UnionConverter.cs

@@ -68,7 +68,7 @@ public object Deserialize<T>(T value) where T : IDataValue
                 case ArrowTypeId.Struct:
                     return GetConverter(typeof(Dictionary<string, object>)).Deserialize(value);
                 default:
-                    throw new NotImplementedException();
+                    throw new NotImplementedException($"Can not deserialize {value.Type} to object");
             }
         }