Fix metadata permadiff for workbench instances (#13454) (GoogleCloudPlatform#3666)

modular-magician · kotatut · commit 612ab86d89a1 · 2025-04-17T10:36:38.000Z
[upstream:390092b17522c92bd0a44e76810888039e0aba16]

Signed-off-by: Modular Magician &lt;magic-modules@google.com&gt;
diff --git a/tfplan2cai/converters/google/resources/services/workbench/workbench_instance.go b/tfplan2cai/converters/google/resources/services/workbench/workbench_instance.go
@@ -115,7 +115,7 @@ var WorkbenchInstanceProvidedMetadata = []string{
 func WorkbenchInstanceMetadataDiffSuppress(k, old, new string, d *schema.ResourceData) bool {
 	// Suppress diffs for the Metadata
 	for _, metadata := range WorkbenchInstanceProvidedMetadata {
-		if strings.Contains(k, metadata) && new == "" {
+		if strings.Contains(k, metadata) {
 			return true
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ var WorkbenchInstanceProvidedMetadata = []string{`
`115`	`115`	`func WorkbenchInstanceMetadataDiffSuppress(k, old, new string, d *schema.ResourceData) bool {`
`116`	`116`	`// Suppress diffs for the Metadata`
`117`	`117`	`for _, metadata := range WorkbenchInstanceProvidedMetadata {`
`118`		`- if strings.Contains(k, metadata) && new == "" {`
	`118`	`+ if strings.Contains(k, metadata) {`
`119`	`119`	`return true`
`120`	`120`	`}`
`121`	`121`	`}`