Skip to content

feat(operator): add karmor.yaml into kubearmor configmap #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tesla59
Copy link
Contributor

@tesla59 tesla59 commented Jan 23, 2025

Purpose of PR?:

Introduces a new field karmor.yaml in the ConfigMap kubearmor-config created by KubeArmor Operator. This field can be mounted into KubeArmor Pods so that the configuration can be done by Viper, deprecating Config Watcher in KubeArmor

Fixes #1920

Does this PR introduce a breaking change?

Configuration using karmor.yaml will eventually replace the other fields in the config map

If the changes in this PR are manually verified, list down the scenarios covered::
Verified both fields in config map are having same values

Additional information for reviewer? :
Continuation of #1862

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@tesla59 tesla59 force-pushed the tesla/config-watcher branch from bf21d83 to dd6ae7c Compare February 22, 2025 10:10
@tesla59 tesla59 force-pushed the tesla/config-watcher branch from 7238b26 to 4cc9231 Compare February 22, 2025 13:54
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Ci checks are failing can you resolve it

@tesla59 tesla59 force-pushed the tesla/config-watcher branch from 7b6c3ae to 4cc9231 Compare March 23, 2025 09:29
@tesla59
Copy link
Contributor Author

tesla59 commented Mar 23, 2025

@Rudra-Sankha-Sinhamahapatra hey. the checks are now passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use viper watcher instead of configmap watcher for config changes
2 participants