feat(core): add username field for alerts and telemetry #2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishabh Soni <[email protected]>
|
Folks, kept username separate from UID to avoid converting u32 to string. Sample Log Json - {
"timestamp": 1743579248,
"updatedTime": "2025-04-02T07:34:08.658306Z",
"hostName": "rootxrishabh",
"hostPPid": 35429,
"hostPid": 209850,
"ppid": 0,
"pid": 209850,
"uid": 1000,
"parentProcessName": "/snap/code/187/usr/share/code/code",
"processName": "/usr/bin/git",
"atags": null,
"type": "HostLog",
"source": "/snap/code/187/usr/share/code/code",
"operation": "Process",
"resource": "/usr/bin/git -c core.quotepath=false -c color.ui=false blame --root --incremental -- KubeArmor/feeder/feeder.go",
"cwd": "/home/rootxrishabh/accuknox/KubeArmor/",
"oid": 0,
"data": "syscall=SYS_EXECVE",
"result": "Passed",
"username": "rootxrishabh"
} |
|
Karmor will need changes to to reflect username field in |
|
@rootxrishabh can you please take a look why CI tests are failing. |
daemon1024
reviewed
Apr 8, 2025
Comment on lines
+59
to
+62
| username, err := user.LookupId(fmt.Sprint(msg.ContextSys.UID)) | ||
| if err != nil { | ||
| mon.Logger.Errf("error occured when fetching user %e", err) | ||
| } |
There was a problem hiding this comment.
How's this going to work?
1000 could be named postgres in a postgres container but it might not exist on the host KubeArmor is in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
This PR adds a username field to both alert and log.
Fixes #2009
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>