Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test should not directly update the pods in the datastore #432

Open
liu-cong opened this issue Mar 1, 2025 · 2 comments
Open

Comments

@liu-cong
Copy link
Contributor

liu-cong commented Mar 1, 2025

What would you like to be added: For the sake of simplicity, our integration tests injects fake pods into the datastore. This essentially bypasses the pod reconciler.

Why is this needed: This gives us coverage on the pod reconciler, and make the code cleaner.

@ahg-g
Copy link
Contributor

ahg-g commented Mar 1, 2025

Addressed in #431

@ahg-g
Copy link
Contributor

ahg-g commented Mar 1, 2025

There are still a number of followups mentioned there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants