Skip to content

Commit 76d9da8

Browse files
authored
feat(xds): rework DeltaXds to use metadata instead of proto (#13467)
## Motivation We shouldn't change the proto schema but instead use metadata. ## Implementation information * Remove proto file and field from Dataplane/ZoneIngress/ZoneEgress. It should be safe since clients (mink) were not able to set this property and only global knew about it * Introduce a new variable for kuma-dp `KUMA_DATAPLANE_RUNTIME_ENVOY_XDS_TRANSPORT_PROTOCOL_VARIANT` which allow setting specific variant of the xds protocol * Keep `kuma.io/xds-transport-protocol-variant` in the k8s to simplify delta testing for the user ## Supporting documentation Fix #13461 --------- Signed-off-by: Lukasz Dziedziak <[email protected]>
1 parent 18317e7 commit 76d9da8

File tree

95 files changed

+925
-1230
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

95 files changed

+925
-1230
lines changed

api/mesh/v1alpha1/dataplane.pb.go

+304-322
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

api/mesh/v1alpha1/dataplane.proto

-4
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ option go_package = "github.com/kumahq/kuma/api/mesh/v1alpha1";
77
import "api/mesh/options.proto";
88
import "api/mesh/v1alpha1/metrics.proto";
99
import "api/mesh/v1alpha1/envoy_admin.proto";
10-
import "api/mesh/v1alpha1/envoy.proto";
1110
import "google/protobuf/duration.proto";
1211
import "google/protobuf/wrappers.proto";
1312
import "validate/validate.proto";
@@ -372,7 +371,4 @@ message Dataplane {
372371
// Deprecated: this feature will be removed for Universal; on Kubernetes, it's
373372
// not needed anymore.
374373
Probes probes = 3;
375-
376-
// EnvoyConfiguration provides additional configuration for the Envoy sidecar.
377-
EnvoyConfiguration envoy = 4;
378374
}

api/mesh/v1alpha1/dataplane/schema.yaml

-12
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,4 @@
11
properties:
2-
envoy:
3-
description: EnvoyConfiguration provides additional configuration for the Envoy
4-
sidecar.
5-
properties:
6-
xdsTransportProtocolVariant:
7-
description: |-
8-
xDSTransportProtocol provides information about protocol used for
9-
configuration exchange between control-plane and Envoy sidecar.
10-
oneOf:
11-
- type: string
12-
- type: integer
13-
type: object
142
labels:
153
additionalProperties:
164
type: string

api/mesh/v1alpha1/dataplaneoverview/schema.yaml

-12
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,6 @@ components:
44
properties:
55
dataplane:
66
properties:
7-
envoy:
8-
description: EnvoyConfiguration provides additional configuration for
9-
the Envoy sidecar.
10-
properties:
11-
xdsTransportProtocolVariant:
12-
description: |-
13-
xDSTransportProtocol provides information about protocol used for
14-
configuration exchange between control-plane and Envoy sidecar.
15-
oneOf:
16-
- type: string
17-
- type: integer
18-
type: object
197
metrics:
208
description: |-
219
Configuration for metrics that should be collected and exposed by the

api/mesh/v1alpha1/envoy.pb.go

-215
This file was deleted.

api/mesh/v1alpha1/envoy.proto

-19
This file was deleted.

0 commit comments

Comments
 (0)