Remove Echo Service from Application Connector (#1098)

Author: Szymongib

components/remote-environment-controller/charts/remote-environments/templates/service.yaml

@@ -21,24 +21,6 @@ spec:
 ---
 apiVersion: v1
 kind: Service
-metadata:
-  name: {{ .Release.Name }}-gateway-echo
-  labels:
-    app: {{ .Release.Name }}-gateway
-    release: {{ .Release.Name }}-gateway
-    heritage: {{ .Release.Service }}-gateway
-spec:
-  type: {{ .Values.service.echo.serviceType }}
-  ports:
-    - port: {{ .Values.service.echo.port }}
-      protocol: TCP
-      name: echo-port
-  selector:
-    app: {{ .Release.Name }}-gateway
-    release: {{ .Release.Name }}-gateway
----
-apiVersion: v1
-kind: Service
 metadata:
   annotations:
     "auth.istio.io/{{ .Values.eventService.service.externalapi.port }}": NONE

components/remote-environment-controller/charts/remote-environments/values.yaml

@@ -13,9 +13,6 @@ deployment:
 service:
   externalapi:
     port: *externalAPIPort
-  echo:
-    serviceType: ClusterIP
-    port: *proxyPort
 
 ingress:
   enabled: true

resources/remote-environments/templates/service.yaml

@@ -21,24 +21,6 @@ spec:
 ---
 apiVersion: v1
 kind: Service
-metadata:
-  name: {{ .Release.Name }}-gateway-echo
-  labels:
-    app: {{ .Release.Name }}-gateway
-    release: {{ .Release.Name }}-gateway
-    heritage: {{ .Release.Service }}-gateway
-spec:
-  type: {{ .Values.service.echo.serviceType }}
-  ports:
-    - port: {{ .Values.service.echo.port }}
-      protocol: TCP
-      name: echo-port
-  selector:
-    app: {{ .Release.Name }}-gateway
-    release: {{ .Release.Name }}-gateway
----
-apiVersion: v1
-kind: Service
 metadata:
   annotations:
     "auth.istio.io/{{ .Values.eventService.service.externalapi.port }}": NONE

resources/remote-environments/values.yaml

@@ -26,9 +26,6 @@ deployment:
 service:
   externalapi:
     port: *externalAPIPort
-  echo:
-    serviceType: ClusterIP
-    port: *proxyPort
 
 ingress:
   enabled: true

tests/connector-service-tests/README.md

@@ -35,7 +35,6 @@ PASSED: test-ec-default-acceptance
 $ kubectl get po --show-all
 NAME                                  READY     STATUS      RESTARTS   AGE
 ec-default-gateway-5dffff49f-drr7n    2/2       Running     0          1h
-echo-service-745c674944-r67zj         1/1       Running     0          1h
 hmc-default-gateway-669965894-5wwv8   2/2       Running     0          3h
 test-ec-default-acceptance            0/1       Completed   0          7m # <<<<<< this one
 ```

tests/gateway-tests/README.md

@@ -41,7 +41,6 @@ PASSED: test-ec-default-acceptance
 $ kubectl get po --show-all
 NAME                                  READY     STATUS      RESTARTS   AGE
 ec-default-gateway-5dffff49f-drr7n    2/2       Running     0          1h
-echo-service-745c674944-r67zj         1/1       Running     0          1h
 hmc-default-gateway-669965894-5wwv8   2/2       Running     0          3h
 test-ec-default-acceptance            0/1       Completed   0          7m # <<<<<< this one
 ```

tests/remote-environment-controller-tests/test/testkit/k8sresources_check.go

@@ -14,7 +14,6 @@ const (
 	gatewayRoleFormat        = "%s-gateway-role"
 	gatewayRoleBindingFormat = "%s-gateway-rolebinding"
 	gatewayApiFormat         = "%s-gateway-external-api"
-	gatewayEchoFormat        = "%s-gateway-echo"
 
 	eventServiceNameFormat = "%s-event-service"
 	eventServiceApiFormat  = "%s-gateway-external-api"
@@ -97,17 +96,12 @@ func (checker *k8sChecker) checkRoleBinding(t *testing.T, errCheckFunc func(*tes
 
 func (checker *k8sChecker) checkServices(t *testing.T, errCheckFunc func(*testing.T, error), resourceCheckFunc func(*testing.T, interface{})) {
 	gatewayApiName := fmt.Sprintf(gatewayApiFormat, checker.remoteEnvName)
-	gatewayEchoName := fmt.Sprintf(gatewayEchoFormat, checker.remoteEnvName)
 	eventsApiName := fmt.Sprintf(eventServiceApiFormat, checker.remoteEnvName)
 
 	gatewayApiSvc, err := checker.client.GetService(gatewayApiName, v1.GetOptions{})
 	errCheckFunc(t, err)
 	resourceCheckFunc(t, gatewayApiSvc)
 
-	gatewayEchoSvc, err := checker.client.GetService(gatewayEchoName, v1.GetOptions{})
-	errCheckFunc(t, err)
-	resourceCheckFunc(t, gatewayEchoSvc)
-
 	eventsSvc, err := checker.client.GetService(eventsApiName, v1.GetOptions{})
 	errCheckFunc(t, err)
 	resourceCheckFunc(t, eventsSvc)