Skip to content

Subscription hashes for EventMesh webhooks are reset if the secret is changed #17951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
marcobebway opened this issue Aug 9, 2023 · 0 comments · Fixed by #17959
Closed
2 tasks done

Subscription hashes for EventMesh webhooks are reset if the secret is changed #17951

marcobebway opened this issue Aug 9, 2023 · 0 comments · Fixed by #17959
Assignees
Labels
area/eventing Issues or PRs related to eventing kind/bug Categorizes issue or PR as related to a bug. priority/critical Priority indication

Comments

@marcobebway
Copy link
Contributor

marcobebway commented Aug 9, 2023

Description

In case the EventMesh is the active backend, the precomputed hashes of the Kyma subscriptions are reset if the secret is changed. This results in deleting and recreating the EventMesh webhooks.

Steps to reproduce

  1. Provision a Kyma cluster
  2. Apply an eventing-webhook-auth secret
  3. Switch backend to EventMesh
  4. Set EVENTING_WEBHOOK_AUTH_ENABLED=true
  5. Create a Kyma subscription
  6. Take a note of the creation timestamp of the EventMesh subscription
  7. Apply another eventing-webhook-auth secret
  8. Take a note of the creation time stamp of the EventMesh subscription
  9. Both creation timestamps don't match, which means the EventMesh subscription was deleted and recreated

Acceptance criteria

  • The precomputed hashes are preserved.
  • The EventMesh webhooks are not deleted if the secret changed.
@marcobebway marcobebway self-assigned this Aug 9, 2023
@marcobebway marcobebway added kind/bug Categorizes issue or PR as related to a bug. area/eventing Issues or PRs related to eventing labels Aug 9, 2023
@marcobebway marcobebway changed the title Subscription hashes for EventMesh webhooks are reset when stopping and starting its controller Subscription hashes for EventMesh webhooks are reset if the secret is changed Aug 9, 2023
@marcobebway marcobebway added the priority/critical Priority indication label Aug 9, 2023
@marcobebway marcobebway linked a pull request Aug 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing kind/bug Categorizes issue or PR as related to a bug. priority/critical Priority indication
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants