[5.4] Stop validating Memcached connection (#19192)

*      Stop validating Memcached connection

*    remove import

*    update tests

Author: themsaid

src/Illuminate/Cache/MemcachedConnector.php

@@ -3,7 +3,6 @@
 namespace Illuminate\Cache;
 
 use Memcached;
-use RuntimeException;
 
 class MemcachedConnector
 {
@@ -15,8 +14,6 @@ class MemcachedConnector
      * @param  array  $options
      * @param  array  $credentials
      * @return \Memcached
-     *
-     * @throws \RuntimeException
      */
     public function connect(array $servers, $connectionId = null, array $options = [], array $credentials = [])
     {
@@ -35,7 +32,7 @@ public function connect(array $servers, $connectionId = null, array $options = [
             }
         }
 
-        return $this->validateConnection($memcached);
+        return $memcached;
     }
 
     /**
@@ -87,25 +84,4 @@ protected function setCredentials($memcached, $credentials)
 
         $memcached->setSaslAuthData($username, $password);
     }
-
-    /**
-     * Validate the given Memcached connection.
-     *
-     * @param  \Memcached  $memcached
-     * @return \Memcached
-     */
-    protected function validateConnection($memcached)
-    {
-        $status = $memcached->getVersion();
-
-        if (! is_array($status)) {
-            throw new RuntimeException('No Memcached servers added.');
-        }
-
-        if (in_array('255.255.255', $status) && count(array_unique($status)) === 1) {
-            throw new RuntimeException('Could not establish Memcached connection.');
-        }
-
-        return $memcached;
-    }
 }

tests/Cache/CacheMemcachedConnectorTest.php

@@ -4,7 +4,6 @@
 
 use Memcached;
 use Mockery as m;
-use RuntimeException;
 use PHPUnit\Framework\TestCase;
 
 class CacheMemcachedConnectorTest extends TestCase
@@ -28,21 +27,6 @@ public function testServersAreAddedCorrectly()
         $this->assertSame($result, $memcached);
     }
 
-    /**
-     * @expectedException RuntimeException
-     */
-    public function testExceptionThrownOnBadConnection()
-    {
-        $memcached = $this->memcachedMockWithAddServer(['255.255.255']);
-
-        $connector = $this->connectorMock();
-        $connector->expects($this->once())
-            ->method('createMemcachedInstance')
-            ->will($this->returnValue($memcached));
-
-        $this->connect($connector);
-    }
-
     public function testServersAreAddedCorrectlyWithPersistentConnection()
     {
         $persistentConnectionId = 'persistent_connection_id';
@@ -110,7 +94,6 @@ protected function memcachedMockWithAddServer($returnedVersion = [])
     {
         $memcached = m::mock('stdClass');
         $memcached->shouldReceive('addServer')->once()->with($this->getHost(), $this->getPort(), $this->getWeight());
-        $memcached->shouldReceive('getVersion')->once()->andReturn($returnedVersion);
         $memcached->shouldReceive('getServerList')->once()->andReturn([]);
 
         return $memcached;