[5.4] array_random helper (#19741)

* Add 'array_random' helper with tests

* replace array_rand usage with new array_random helper

* Make random test more resilient

Author: calebporzio

src/Illuminate/Database/Connectors/ConnectionFactory.php

@@ -138,7 +138,7 @@ protected function getWriteConfig(array $config)
     protected function getReadWriteConfig(array $config, $type)
     {
         return isset($config[$type][0])
-                        ? $config[$type][array_rand($config[$type])]
+                        ? Arr::random($config[$type])
                         : $config[$type];
     }
 

src/Illuminate/Support/Arr.php

@@ -438,6 +438,17 @@ public static function pull(&$array, $key, $default = null)
         return $value;
     }
 
+    /**
+     * Get a random value from an array.
+     *
+     * @param  array   $array
+     * @return mixed
+     */
+    public static function random($array)
+    {
+        return $array[array_rand($array)];
+    }
+
     /**
      * Set an array item to a given value using "dot" notation.
      *

src/Illuminate/Support/helpers.php

@@ -245,6 +245,19 @@ function array_pull(&$array, $key, $default = null)
     }
 }
 
+if (! function_exists('array_random')) {
+    /**
+     * Get a random value from an array.
+     *
+     * @param  array   $array
+     * @return mixed
+     */
+    function array_random($array)
+    {
+        return Arr::random($array);
+    }
+}
+
 if (! function_exists('array_set')) {
     /**
      * Set an array item to a given value using "dot" notation.

tests/Support/SupportArrTest.php

@@ -399,6 +399,14 @@ public function testPull()
         $this->assertEquals(['emails' => ['[email protected]' => 'Joe', 'jane@localhost' => 'Jane']], $array);
     }
 
+    public function testRandom()
+    {
+        $randomValue = Arr::random(['foo', 'bar', 'baz']);
+
+        $this->assertInternalType('string', $randomValue);
+        $this->assertContains($randomValue, ['foo', 'bar', 'baz']);
+    }
+
     public function testSet()
     {
         $array = ['products' => ['desk' => ['price' => 100]]];