Attempt to use atomic cache operation when checking for overlaps.

taylorotwell · taylorotwell · commit 8ebb5b859ae8 · 2017-03-16T09:51:05.000-05:00
This will help prevent race conditions.
diff --git a/src/Illuminate/Console/Scheduling/Event.php b/src/Illuminate/Console/Scheduling/Event.php
@@ -160,8 +160,9 @@ public function getDefaultOutput()
      */
     public function run(Container $container)
     {
-        if ($this->withoutOverlapping) {
-            $this->cache->put($this->mutexName(), true, 1440);
+        if ($this->withoutOverlapping &&
+            ! $this->cache->add($this->mutexName(), true, 1440)) {
+            return;
         }
 
         $this->runInBackground

Original file line number	Diff line number	Diff line change
`@@ -160,8 +160,9 @@ public function getDefaultOutput()`
`160`	`160`	`*/`
`161`	`161`	`public function run(Container $container)`
`162`	`162`	`{`
`163`		`- if ($this->withoutOverlapping) {`
`164`		`- $this->cache->put($this->mutexName(), true, 1440);`
	`163`	`+ if ($this->withoutOverlapping &&`
	`164`	`+ ! $this->cache->add($this->mutexName(), true, 1440)) {`
	`165`	`+ return;`
`165`	`166`	`}`
`166`	`167`
`167`	`168`	`$this->runInBackground`