Optimize UrlGenerator->isValidUrl() (#18566)

vlakoff · taylorotwell · commit 94272a4c30e2 · 2017-03-29T16:57:27.000-05:00
diff --git a/src/Illuminate/Routing/UrlGenerator.php b/src/Illuminate/Routing/UrlGenerator.php
@@ -444,7 +444,7 @@ public function format($root, $path)
      */
     public function isValidUrl($path)
     {
-        if (! Str::startsWith($path, ['#', '//', 'mailto:', 'tel:', 'http://', 'https://'])) {
+        if (! preg_match('~^(#|//|https?://|mailto:|tel:)~', $path)) {
             return filter_var($path, FILTER_VALIDATE_URL) !== false;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -444,7 +444,7 @@ public function format($root, $path)`
`444`	`444`	`*/`
`445`	`445`	`public function isValidUrl($path)`
`446`	`446`	`{`
`447`		`- if (! Str::startsWith($path, ['#', '//', 'mailto:', 'tel:', 'http://', 'https://'])) {`
	`447`	`+ if (! preg_match('~^(#\|//\|https?://\|mailto:\|tel:)~', $path)) {`
`448`	`448`	`return filter_var($path, FILTER_VALIDATE_URL) !== false;`
`449`	`449`	`}`
`450`	`450`