newModelQuery rename

Author: taylorotwell

src/Illuminate/Database/Eloquent/Builder.php

@@ -219,9 +219,7 @@ public function whereKeyNot($id)
     public function where($column, $operator = null, $value = null, $boolean = 'and')
     {
         if ($column instanceof Closure) {
-            $query = $this->model->newUneagerQueryWithoutScopes();
-
-            $column($query);
+            $column($query = $this->model->newModelQuery());
 
             $this->query->addNestedWhereQuery($query->getQuery(), $boolean);
         } else {

src/Illuminate/Database/Eloquent/Model.php

@@ -530,7 +530,7 @@ public function push()
      */
     public function save(array $options = [])
     {
-        $query = $this->newUneagerQueryWithoutScopes();
+        $query = $this->newModelQuery();
 
         // If the "saving" event returns false we'll bail out of the save and return
         // false, indicating that the save failed. This provides a chance for any
@@ -815,7 +815,7 @@ public function forceDelete()
      */
     protected function performDeleteOnModel()
     {
-        $this->setKeysForSaveQuery($this->newUneagerQueryWithoutScopes())->delete();
+        $this->setKeysForSaveQuery($this->newModelQuery())->delete();
 
         $this->exists = false;
     }
@@ -840,6 +840,18 @@ public function newQuery()
         return $this->registerGlobalScopes($this->newQueryWithoutScopes());
     }
 
+    /**
+     * Get a new query builder that doesn't have any global scopes or eager loading.
+     *
+     * @return \Illuminate\Database\Eloquent\Builder|static
+     */
+    public function newModelQuery()
+    {
+        return $this->newEloquentBuilder(
+            $this->newBaseQueryBuilder()
+        )->setModel($this);
+    }
+
     /**
      * Get a new query builder with no relationships loaded.
      *
@@ -874,26 +886,11 @@ public function registerGlobalScopes($builder)
      */
     public function newQueryWithoutScopes()
     {
-        return $this->newUneagerQueryWithoutScopes()
+        return $this->newModelQuery()
                     ->with($this->with)
                     ->withCount($this->withCount);
     }
 
-    /**
-     * Get a new query builder that doesn't have any global scopes or eager loading.
-     *
-     * @return \Illuminate\Database\Eloquent\Builder|static
-     */
-    public function newUneagerQueryWithoutScopes()
-    {
-        $builder = $this->newEloquentBuilder($this->newBaseQueryBuilder());
-
-        // Once we have the query builders, we will set the model instances so the
-        // builder can easily access any information it may need from the model
-        // while it is constructing and executing various queries against it.
-        return $builder->setModel($this);
-    }
-
     /**
      * Get a new query instance without a given scope.
      *
@@ -902,9 +899,7 @@ public function newUneagerQueryWithoutScopes()
      */
     public function newQueryWithoutScope($scope)
     {
-        $builder = $this->newQuery();
-
-        return $builder->withoutGlobalScope($scope);
+        return $this->newQuery()->withoutGlobalScope($scope);
     }
 
     /**

src/Illuminate/Database/Eloquent/SoftDeletes.php

@@ -49,7 +49,7 @@ protected function performDeleteOnModel()
         if ($this->forceDeleting) {
             $this->exists = false;
 
-            return $this->newUneagerQueryWithoutScopes()->where($this->getKeyName(), $this->getKey())->forceDelete();
+            return $this->newModelQuery()->where($this->getKeyName(), $this->getKey())->forceDelete();
         }
 
         return $this->runSoftDelete();
@@ -62,7 +62,7 @@ protected function performDeleteOnModel()
      */
     protected function runSoftDelete()
     {
-        $query = $this->newUneagerQueryWithoutScopes()->where($this->getKeyName(), $this->getKey());
+        $query = $this->newModelQuery()->where($this->getKeyName(), $this->getKey());
 
         $time = $this->freshTimestamp();
 

tests/Database/DatabaseEloquentBuilderTest.php

@@ -575,7 +575,7 @@ public function testNestedWhere()
         $nestedRawQuery = $this->getMockQueryBuilder();
         $nestedQuery->shouldReceive('getQuery')->once()->andReturn($nestedRawQuery);
         $model = $this->getMockModel()->makePartial();
-        $model->shouldReceive('newUneagerQueryWithoutScopes')->once()->andReturn($nestedQuery);
+        $model->shouldReceive('newModelQuery')->once()->andReturn($nestedQuery);
         $builder = $this->getBuilder();
         $builder->getQuery()->shouldReceive('from');
         $builder->setModel($model);