rename scheduler

Author: MarcoPolo

gossipsub_test.go

@@ -3337,7 +3337,7 @@ func BenchmarkAllocDoDropRPC(b *testing.B) {
 	}
 }
 
-func TestRarestFirstRPCScheduler(t *testing.T) {
+func TestRoundRobinMessageIDScheduler(t *testing.T) {
 	const maxNumPeers = 256
 	const maxNumMessages = 1_000
 
@@ -3347,7 +3347,7 @@ func TestRarestFirstRPCScheduler(t *testing.T) {
 
 		output := make([]pendingRPC, 0, numMessages*numPeers)
 
-		var strategy RarestFirstRPCScheduler
+		var strategy RoundRobinMessageIDScheduler
 
 		peers := make([]peer.ID, numPeers)
 		for i := 0; i < int(numPeers); i++ {
@@ -3429,10 +3429,10 @@ func TestRarestFirstRPCScheduler(t *testing.T) {
 	}
 }
 
-func BenchmarkRarestFirstRPCScheduler(b *testing.B) {
+func BenchmarkRoundRobinMessageIDScheduler(b *testing.B) {
 	const numPeers = 1_000
 	const numMessages = 1_000
-	var strategy RarestFirstRPCScheduler
+	var strategy RoundRobinMessageIDScheduler
 
 	peers := make([]peer.ID, numPeers)
 	for i := range int(numPeers) {

messagebatch.go

@@ -31,18 +31,19 @@ type pendingRPC struct {
 	rpc  *RPC
 }
 
-type RarestFirstRPCScheduler struct {
+// RoundRobinMessageIDScheduler schedules outgoing RPCs in round-robin order of message IDs.
+type RoundRobinMessageIDScheduler struct {
 	rpcs map[string][]pendingRPC
 }
 
-func (s *RarestFirstRPCScheduler) AddRPC(peer peer.ID, msgID string, rpc *RPC) {
+func (s *RoundRobinMessageIDScheduler) AddRPC(peer peer.ID, msgID string, rpc *RPC) {
 	if s.rpcs == nil {
 		s.rpcs = make(map[string][]pendingRPC)
 	}
 	s.rpcs[msgID] = append(s.rpcs[msgID], pendingRPC{peer: peer, rpc: rpc})
 }
 
-func (s *RarestFirstRPCScheduler) All() iter.Seq2[peer.ID, *RPC] {
+func (s *RoundRobinMessageIDScheduler) All() iter.Seq2[peer.ID, *RPC] {
 	return func(yield func(peer.ID, *RPC) bool) {
 		for len(s.rpcs) > 0 {
 			for msgID, rpcs := range s.rpcs {

topic.go

@@ -228,7 +228,7 @@ type BatchPubOpt func(pub *BatchPublishOptions) error
 
 func setDefaultBatchPublishOptions(opts *BatchPublishOptions) {
 	if opts.Strategy == nil {
-		opts.Strategy = &RarestFirstRPCScheduler{}
+		opts.Strategy = &RoundRobinMessageIDScheduler{}
 	}
 }