Skip to content
This repository was archived by the owner on May 26, 2022. It is now read-only.

Commit 03c310e

Browse files
add support for the resource manager
1 parent 0531f9f commit 03c310e

File tree

6 files changed

+57
-22
lines changed

6 files changed

+57
-22
lines changed

go.mod

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@ require (
66
github.com/ipfs/go-log/v2 v2.4.0
77
github.com/libp2p/go-addr-util v0.1.0
88
github.com/libp2p/go-conn-security-multistream v0.3.0
9-
github.com/libp2p/go-libp2p-core v0.13.0
9+
github.com/libp2p/go-libp2p-core v0.13.1-0.20211231121257-5fcc7b607478
1010
github.com/libp2p/go-libp2p-peerstore v0.6.0
11-
github.com/libp2p/go-libp2p-quic-transport v0.13.0
11+
github.com/libp2p/go-libp2p-quic-transport v0.15.1-0.20220101100156-1e9d06560d6a
1212
github.com/libp2p/go-libp2p-testing v0.5.0
13-
github.com/libp2p/go-libp2p-transport-upgrader v0.6.0
13+
github.com/libp2p/go-libp2p-transport-upgrader v0.6.1-0.20220101094616-076e334df9ce
1414
github.com/libp2p/go-libp2p-yamux v0.5.0
1515
github.com/libp2p/go-stream-muxer-multistream v0.3.0
16-
github.com/libp2p/go-tcp-transport v0.4.0
16+
github.com/libp2p/go-tcp-transport v0.4.1-0.20220101094718-c6ace780f863
1717
github.com/multiformats/go-multiaddr v0.4.0
1818
github.com/multiformats/go-multiaddr-fmt v0.1.0
1919
github.com/stretchr/testify v1.7.0

go.sum

+10-12
Original file line numberDiff line numberDiff line change
@@ -279,25 +279,24 @@ github.com/libp2p/go-libp2p-core v0.5.1/go.mod h1:uN7L2D4EvPCvzSH5SrhR72UWbnSGpt
279279
github.com/libp2p/go-libp2p-core v0.8.0/go.mod h1:FfewUH/YpvWbEB+ZY9AQRQ4TAD8sJBt/G1rVvhz5XT8=
280280
github.com/libp2p/go-libp2p-core v0.10.0/go.mod h1:ECdxehoYosLYHgDDFa2N4yE8Y7aQRAMf0sX9mf2sbGg=
281281
github.com/libp2p/go-libp2p-core v0.12.0/go.mod h1:ECdxehoYosLYHgDDFa2N4yE8Y7aQRAMf0sX9mf2sbGg=
282-
github.com/libp2p/go-libp2p-core v0.13.0 h1:IFG/s8dN6JN2OTrXX9eq2wNU/Zlz2KLdwZUp5FplgXI=
283-
github.com/libp2p/go-libp2p-core v0.13.0/go.mod h1:ECdxehoYosLYHgDDFa2N4yE8Y7aQRAMf0sX9mf2sbGg=
282+
github.com/libp2p/go-libp2p-core v0.13.1-0.20211231121257-5fcc7b607478 h1:V4qhaW1u7hJ54vditELylooLRTTcc7wmirh0yPgcxaA=
283+
github.com/libp2p/go-libp2p-core v0.13.1-0.20211231121257-5fcc7b607478/go.mod h1:ECdxehoYosLYHgDDFa2N4yE8Y7aQRAMf0sX9mf2sbGg=
284284
github.com/libp2p/go-libp2p-mplex v0.4.1 h1:/pyhkP1nLwjG3OM+VuaNJkQT/Pqq73WzB3aDN3Fx1sc=
285285
github.com/libp2p/go-libp2p-mplex v0.4.1/go.mod h1:cmy+3GfqfM1PceHTLL7zQzAAYaryDu6iPSC+CIb094g=
286286
github.com/libp2p/go-libp2p-peerstore v0.6.0 h1:HJminhQSGISBIRb93N6WK3t6Fa8OOTnHd/VBjL4mY5A=
287287
github.com/libp2p/go-libp2p-peerstore v0.6.0/go.mod h1:DGEmKdXrcYpK9Jha3sS7MhqYdInxJy84bIPtSu65bKc=
288288
github.com/libp2p/go-libp2p-pnet v0.2.0 h1:J6htxttBipJujEjz1y0a5+eYoiPcFHhSYHH6na5f0/k=
289289
github.com/libp2p/go-libp2p-pnet v0.2.0/go.mod h1:Qqvq6JH/oMZGwqs3N1Fqhv8NVhrdYcO0BW4wssv21LA=
290-
github.com/libp2p/go-libp2p-quic-transport v0.13.0 h1:MTVojS4AnGD/rng6rF/HXEqwMHL27rHUEf3DaqSdnUw=
291-
github.com/libp2p/go-libp2p-quic-transport v0.13.0/go.mod h1:39/ZWJ1TW/jx1iFkKzzUg00W6tDJh73FC0xYudjr7Hc=
290+
github.com/libp2p/go-libp2p-quic-transport v0.15.1-0.20220101100156-1e9d06560d6a h1:HITWbMM1PmUJqYs2DK3iT09SIz7Bp85CC3yEkZ/ApQs=
291+
github.com/libp2p/go-libp2p-quic-transport v0.15.1-0.20220101100156-1e9d06560d6a/go.mod h1:PnciuaUDq/F8OHLiyNGeof9c6PIJQbEHxEbhK/ceNMw=
292292
github.com/libp2p/go-libp2p-testing v0.1.2-0.20200422005655-8775583591d8/go.mod h1:Qy8sAncLKpwXtS2dSnDOP8ktexIAHKu+J+pnZOFZLTc=
293293
github.com/libp2p/go-libp2p-testing v0.4.0/go.mod h1:Q+PFXYoiYFN5CAEG2w3gLPEzotlKsNSbKQ/lImlOWF0=
294294
github.com/libp2p/go-libp2p-testing v0.5.0 h1:bTjC29TTQ/ODq0ld3+0KLq3irdA5cAH3OMbRi0/QsvE=
295295
github.com/libp2p/go-libp2p-testing v0.5.0/go.mod h1:QBk8fqIL1XNcno/l3/hhaIEn4aLRijpYOR+zVjjlh+A=
296296
github.com/libp2p/go-libp2p-tls v0.3.0 h1:8BgvUJiOTcj0Gp6XvEicF0rL5aUtRg/UzEdeZDmDlC8=
297297
github.com/libp2p/go-libp2p-tls v0.3.0/go.mod h1:fwF5X6PWGxm6IDRwF3V8AVCCj/hOd5oFlg+wo2FxJDY=
298-
github.com/libp2p/go-libp2p-transport-upgrader v0.5.0/go.mod h1:Rc+XODlB3yce7dvFV4q/RmyJGsFcCZRkeZMu/Zdg0mo=
299-
github.com/libp2p/go-libp2p-transport-upgrader v0.6.0 h1:GfMCU+2aGGEm1zW3UcOz6wYSn8tXQalFfVfcww99i5A=
300-
github.com/libp2p/go-libp2p-transport-upgrader v0.6.0/go.mod h1:1e07y1ZSZdHo9HPbuU8IztM1Cj+DR5twgycb4pnRzRo=
298+
github.com/libp2p/go-libp2p-transport-upgrader v0.6.1-0.20220101094616-076e334df9ce h1:c/1P03KzVcucwj8CaREviCNpYHLYfyuKQzFLT80BnZ4=
299+
github.com/libp2p/go-libp2p-transport-upgrader v0.6.1-0.20220101094616-076e334df9ce/go.mod h1:gRl3evtqJSAjlPvzYGVp3zBPWd0/ni/DUhB3wA67Krg=
301300
github.com/libp2p/go-libp2p-yamux v0.5.0 h1:ZzmUhbQE+X7NuYUT2naxN31JyebZfRmpZVhKtRP13ys=
302301
github.com/libp2p/go-libp2p-yamux v0.5.0/go.mod h1:AyR8k5EzyM2QN9Bbdg6X1SkVVuqLwTGf0L4DFq9g6po=
303302
github.com/libp2p/go-maddr-filter v0.1.0/go.mod h1:VzZhTXkMucEGGEOSKddrwGiOv0tUhgnKqNEmIAz/bPU=
@@ -321,14 +320,14 @@ github.com/libp2p/go-sockaddr v0.1.0 h1:Y4s3/jNoryVRKEBrkJ576F17CPOaMIzUeCsg7dlT
321320
github.com/libp2p/go-sockaddr v0.1.0/go.mod h1:syPvOmNs24S3dFVGJA1/mrqdeijPxLV2Le3BRLKd68k=
322321
github.com/libp2p/go-stream-muxer-multistream v0.3.0 h1:TqnSHPJEIqDEO7h1wZZ0p3DXdvDSiLHQidKKUGZtiOY=
323322
github.com/libp2p/go-stream-muxer-multistream v0.3.0/go.mod h1:yDh8abSIzmZtqtOt64gFJUXEryejzNb0lisTt+fAMJA=
324-
github.com/libp2p/go-tcp-transport v0.4.0 h1:VDyg4j6en3OuXf90gfDQh5Sy9KowO9udnd0OU8PP6zg=
325-
github.com/libp2p/go-tcp-transport v0.4.0/go.mod h1:0y52Rwrn4076xdJYu/51/qJIdxz+EWDAOG2S45sV3VI=
323+
github.com/libp2p/go-tcp-transport v0.4.1-0.20220101094718-c6ace780f863 h1:otblp7EBZUfzrz5TyD8kRSehvT5AWiD18lfnFkvpreE=
324+
github.com/libp2p/go-tcp-transport v0.4.1-0.20220101094718-c6ace780f863/go.mod h1:ftGTKY2jtyDjT6jdjHYxLQO7tPnnPrr3Z28qeSvcLiU=
326325
github.com/libp2p/go-yamux v1.4.1 h1:P1Fe9vF4th5JOxxgQvfbOHkrGqIZniTLf+ddhZp8YTI=
327326
github.com/libp2p/go-yamux v1.4.1/go.mod h1:fr7aVgmdNGJK+N1g+b6DW6VxzbRCjCOejR/hkmpooHE=
328327
github.com/lightstep/lightstep-tracer-common/golang/gogo v0.0.0-20190605223551-bc2310a04743/go.mod h1:qklhhLq1aX+mtWk9cPHPzaBjWImj5ULL6C7HFJtXQMM=
329328
github.com/lightstep/lightstep-tracer-go v0.18.1/go.mod h1:jlF1pusYV4pidLvZ+XD0UBX0ZE6WURAspgAczcDHrL4=
330-
github.com/lucas-clemente/quic-go v0.23.0 h1:5vFnKtZ6nHDFsc/F3uuiF4T3y/AXaQdxjUqiVw26GZE=
331-
github.com/lucas-clemente/quic-go v0.23.0/go.mod h1:paZuzjXCE5mj6sikVLMvqXk8lJV2AsqtJ6bDhjEfxx0=
329+
github.com/lucas-clemente/quic-go v0.24.0 h1:ToR7SIIEdrgOhgVTHvPgdVRJfgVy+N0wQAagH7L4d5g=
330+
github.com/lucas-clemente/quic-go v0.24.0/go.mod h1:paZuzjXCE5mj6sikVLMvqXk8lJV2AsqtJ6bDhjEfxx0=
332331
github.com/lunixbochs/vtclean v1.0.0/go.mod h1:pHhQNgMf3btfWnGBVipUOjRYhoOsdGqdm/+2c2E2WMI=
333332
github.com/lyft/protoc-gen-validate v0.0.13/go.mod h1:XbGvPuh87YZc5TdIa2/I4pLk0QoUACkjt2znoq26NVQ=
334333
github.com/magiconair/properties v1.8.0/go.mod h1:PppfXfuXeibc/6YijjN8zIbojt8czPbwD3XqdrwzmxQ=
@@ -747,7 +746,6 @@ golang.org/x/sys v0.0.0-20210317225723-c4fcb01b228e/go.mod h1:h1NjWce9XRLGQEsW7w
747746
golang.org/x/sys v0.0.0-20210330210617-4fbd30eecc44/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
748747
golang.org/x/sys v0.0.0-20210423082822-04245dca01da/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
749748
golang.org/x/sys v0.0.0-20210510120138-977fb7262007/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
750-
golang.org/x/sys v0.0.0-20210511113859-b0526f3d8744/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
751749
golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c h1:F1jZWGFhYfh0Ci55sIpILtKKK8p3i2/krTr0H1rg74I=
752750
golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
753751
golang.org/x/term v0.0.0-20201117132131-f5c789dd3221/go.mod h1:Nr5EML6q2oocZ2LXRh80K7BxOlk5/8JxuGnuhpl+muw=

swarm.go

+16
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,13 @@ func WithDialTimeoutLocal(t time.Duration) Option {
7676
}
7777
}
7878

79+
func WithResourceManager(m network.ResourceManager) Option {
80+
return func(s *Swarm) error {
81+
s.rcmgr = m
82+
return nil
83+
}
84+
}
85+
7986
// Swarm is a connection muxer, allowing connections to other peers to
8087
// be opened and closed, while still using the same Chan for all
8188
// communication. The Chan sends/receives Messages, which note the
@@ -88,6 +95,8 @@ type Swarm struct {
8895
// down before continuing.
8996
refs sync.WaitGroup
9097

98+
rcmgr network.ResourceManager
99+
91100
local peer.ID
92101
peers peerstore.Peerstore
93102

@@ -156,6 +165,9 @@ func NewSwarm(local peer.ID, peers peerstore.Peerstore, opts ...Option) (*Swarm,
156165
return nil, err
157166
}
158167
}
168+
if s.rcmgr == nil {
169+
s.rcmgr = network.NullResourceManager
170+
}
159171

160172
s.dsync = newDialSync(s.dialWorkerLoop)
161173
s.limiter = newDialLimiter(s.dialAddr)
@@ -586,6 +598,10 @@ func (s *Swarm) String() string {
586598
return fmt.Sprintf("<Swarm %s>", s.LocalPeer())
587599
}
588600

601+
func (s *Swarm) ResourceManager() network.ResourceManager {
602+
return s.rcmgr
603+
}
604+
589605
// Swarm is a Network.
590606
var _ network.Network = (*Swarm)(nil)
591607
var _ transport.TransportNetwork = (*Swarm)(nil)

swarm_conn.go

+20-4
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ type Conn struct {
4242
stat network.ConnStats
4343
}
4444

45+
var _ network.Conn = &Conn{}
46+
4547
func (c *Conn) ID() string {
4648
// format: <first 10 chars of peer id>-<global conn ordinal>
4749
return fmt.Sprintf("%s-%d", c.RemotePeer().Pretty()[0:10], c.id)
@@ -109,9 +111,14 @@ func (c *Conn) start() {
109111
if err != nil {
110112
return
111113
}
114+
scope, err := c.swarm.ResourceManager().OpenStream(c.RemotePeer(), network.DirInbound)
115+
if err != nil {
116+
ts.Reset()
117+
continue
118+
}
112119
c.swarm.refs.Add(1)
113120
go func() {
114-
s, err := c.addStream(ts, network.DirInbound)
121+
s, err := c.addStream(ts, network.DirInbound, scope)
115122

116123
// Don't defer this. We don't want to block
117124
// swarm shutdown on the connection handler.
@@ -186,19 +193,23 @@ func (c *Conn) NewStream(ctx context.Context) (network.Stream, error) {
186193
}
187194
}
188195

196+
scope, err := c.swarm.ResourceManager().OpenStream(c.RemotePeer(), network.DirOutbound)
197+
if err != nil {
198+
return nil, err
199+
}
189200
ts, err := c.conn.OpenStream(ctx)
190-
191201
if err != nil {
192202
return nil, err
193203
}
194-
return c.addStream(ts, network.DirOutbound)
204+
return c.addStream(ts, network.DirOutbound, scope)
195205
}
196206

197-
func (c *Conn) addStream(ts mux.MuxedStream, dir network.Direction) (*Stream, error) {
207+
func (c *Conn) addStream(ts mux.MuxedStream, dir network.Direction, scope network.StreamManagementScope) (*Stream, error) {
198208
c.streams.Lock()
199209
// Are we still online?
200210
if c.streams.m == nil {
201211
c.streams.Unlock()
212+
scope.Done()
202213
ts.Reset()
203214
return nil, ErrConnClosed
204215
}
@@ -207,6 +218,7 @@ func (c *Conn) addStream(ts mux.MuxedStream, dir network.Direction) (*Stream, er
207218
s := &Stream{
208219
stream: ts,
209220
conn: c,
221+
scope: scope,
210222
stat: network.Stats{
211223
Direction: dir,
212224
Opened: time.Now(),
@@ -244,3 +256,7 @@ func (c *Conn) GetStreams() []network.Stream {
244256
}
245257
return streams
246258
}
259+
260+
func (c *Conn) Scope() network.ConnectionScope {
261+
return c.conn.Scope()
262+
}

swarm_stream.go

+5
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ type Stream struct {
2121

2222
stream mux.MuxedStream
2323
conn *Conn
24+
scope network.StreamScope
2425

2526
closeOnce sync.Once
2627

@@ -154,3 +155,7 @@ func (s *Stream) SetWriteDeadline(t time.Time) error {
154155
func (s *Stream) Stat() network.Stats {
155156
return s.stat
156157
}
158+
159+
func (s *Stream) Scope() network.StreamScope {
160+
return s.scope
161+
}

testing/testing.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ func GenSwarm(t *testing.T, opts ...Option) *swarm.Swarm {
142142
if cfg.disableReuseport {
143143
tcpOpts = append(tcpOpts, tcp.DisableReuseport())
144144
}
145-
tcpTransport, err := tcp.NewTCPTransport(upgrader, tcpOpts...)
145+
tcpTransport, err := tcp.NewTCPTransport(upgrader, nil, tcpOpts...)
146146
require.NoError(t, err)
147147
if err := s.AddTransport(tcpTransport); err != nil {
148148
t.Fatal(err)
@@ -154,7 +154,7 @@ func GenSwarm(t *testing.T, opts ...Option) *swarm.Swarm {
154154
}
155155
}
156156
if !cfg.disableQUIC {
157-
quicTransport, err := quic.NewTransport(p.PrivKey, nil, cfg.connectionGater)
157+
quicTransport, err := quic.NewTransport(p.PrivKey, nil, cfg.connectionGater, nil)
158158
if err != nil {
159159
t.Fatal(err)
160160
}

0 commit comments

Comments
 (0)