Skip to content

Commit f3ec538

Browse files
authored
fix!: remove event emitter type from interfaces (#2196)
All code should be using `TypedEventEmitter` instead of `EventEmitter` so remove the re-export from the interfaces package. BREAKING CHANGE: removed EventEmitter re-export - please use TypedEventEmitter instead
1 parent 0b4a2ee commit f3ec538

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

packages/interface/src/events.ts

-3
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,6 @@ class CustomEventPolyfill<T = any> extends Event {
117117

118118
export const CustomEvent = globalThis.CustomEvent ?? CustomEventPolyfill
119119

120-
// TODO: remove this in v1
121-
export { TypedEventEmitter as EventEmitter }
122-
123120
// create a setMaxListeners that doesn't break browser usage
124121
export const setMaxListeners: typeof nodeSetMaxListeners = (n, ...eventTargets) => {
125122
try {

packages/peer-discovery-mdns/src/mdns.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { CustomEvent, EventEmitter } from '@libp2p/interface/events'
1+
import { CustomEvent, TypedEventEmitter } from '@libp2p/interface/events'
22
import { peerDiscovery } from '@libp2p/interface/peer-discovery'
33
import multicastDNS from 'multicast-dns'
44
import * as query from './query.js'
@@ -23,7 +23,7 @@ export interface MulticastDNSComponents {
2323
logger: ComponentLogger
2424
}
2525

26-
export class MulticastDNS extends EventEmitter<PeerDiscoveryEvents> implements PeerDiscovery, Startable {
26+
export class MulticastDNS extends TypedEventEmitter<PeerDiscoveryEvents> implements PeerDiscovery, Startable {
2727
public mdns?: multicastDNS.MulticastDNS
2828

2929
private readonly log: Logger

0 commit comments

Comments
 (0)