Skip to content

autogen.sh script generates files under crypto/arch/* that are not currently covered by .gitignore #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nak3 opened this issue May 4, 2025 · 2 comments · Fixed by #1161

Comments

@nak3
Copy link
Contributor

nak3 commented May 4, 2025

When running the following commands:

$ git clone https://github.com/libressl/portable.git
$ cd portable
$ ./autogen.sh

Files are generated in crypto/arch/*/*, but these files are not listed in .gitignore.

$ git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	crypto/arch/aarch64/
	crypto/arch/alpha/
	crypto/arch/amd64/
	crypto/arch/arm/
	crypto/arch/hppa/
	crypto/arch/i386/
	crypto/arch/m88k/
	crypto/arch/mips64/
	crypto/arch/powerpc/
	crypto/arch/powerpc64/
	crypto/arch/riscv64/
	crypto/arch/sh/
	crypto/arch/sparc64/

At first, I thought of simply adding them to .gitignore, but when I looked at https://github.com/libressl/portable/tree/master/crypto/arch, I noticed that only loongarch64 and mips are under version control, which confused me — so I decided to open an issue.

@botovq
Copy link
Contributor

botovq commented May 4, 2025

loongarch64 and mips are under version control in portable because these aren't supported by OpenBSD natively, but there was interest in using libressl on these architectures. So I think we should ignore crypto/arch/* and add an exception !crypto/arch/loongarch64 next to the one that is already there for mips.

@nak3
Copy link
Contributor Author

nak3 commented May 4, 2025

Ah, I understand. Thank you for the explanation.
I filed the PR #1161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants