Skip to content

Support new EIP712 spec #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
williamchong opened this issue Aug 2, 2018 · 2 comments
Open

Support new EIP712 spec #683

williamchong opened this issue Aug 2, 2018 · 2 comments
Assignees
@williamchong @nnkken

Comments

@williamchong
Copy link
Member

williamchong commented Aug 2, 2018 •
edited
Loading

EIP712 specification has be finalized and there were some changes
Might need to update our current code/flow

related: #629
@williamchong
Copy link
Member Author

。。。 was this done actually @nnkken @mckingho

@nnkken
Copy link
Contributor

nnkken commented Dec 12, 2018

No, since the smart contract is not updated yet.
But @mckingho already knows how to do it, should be only changing a few lines of code.

@williamchong williamchong reopened this Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamchong williamchong

@nnkken nnkken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@williamchong @nnkken