CI: run Clippy on web-default features for Web-compatible crates (#2434)

Author: Twey

.github/workflows/rust.yml

@@ -209,9 +209,13 @@ jobs:
         cargo clippy --all-targets --all-features --target x86_64-unknown-linux-gnu --locked
     - name: Run clippy
       run: |
-        cargo clippy --all-targets --all-features --locked
-        cargo clippy --no-default-features --features kubernetes --locked
-        cargo clippy --no-default-features --locked
+        cargo clippy --locked --all-targets --all-features
+        cargo clippy --locked --no-default-features --features kubernetes
+        cargo clippy --locked --no-default-features
+        cargo clippy --locked --target wasm32-unknown-unknown --no-default-features --features web-default \
+          -p linera-client \
+          -p linera-rpc \
+          -p linera-views
     - name: Run cargo doc
       run: |
         cargo doc --locked --all-features

linera-rpc/Cargo.toml

@@ -39,6 +39,8 @@ web = [
     "linera-execution/web",
 ]
 
+web-default = ["web"]
+
 [dependencies]
 anyhow.workspace = true
 async-trait.workspace = true

linera-views/Cargo.toml

@@ -23,6 +23,7 @@ metrics = ["dep:hex", "linera-base/metrics", "linera-views-derive/metrics"]
 test = ["tokio/macros", "rand"]
 web = ["linera-base/web"]
 indexeddb = ["indexed_db_futures", "wasm-bindgen"]
+web-default = ["web", "indexeddb"]
 
 dynamodb = ["aws-config", "aws-sdk-dynamodb", "aws-smithy-types"]
 scylladb = ["scylla"]

linera-views/src/indexed_db.rs

@@ -1,7 +1,7 @@
 // Copyright (c) Zefchain Labs, Inc.
 // SPDX-License-Identifier: Apache-2.0
 
-use std::{fmt::Debug, sync::Arc};
+use std::{fmt::Debug, rc::Rc};
 
 use futures::future;
 use indexed_db_futures::{js_sys, prelude::*, web_sys};
@@ -44,7 +44,7 @@ const DATABASE_NAME: &str = "linera";
 /// API](https://developer.mozilla.org/en-US/docs/Web/API/IndexedDB_API#:~:text=IndexedDB%20is%20a%20low%2Dlevel,larger%20amounts%20of%20structured%20data.).
 pub struct IndexedDbStore {
     /// The database used for storing the data.
-    pub database: Arc<IdbDatabase>,
+    pub database: Rc<IdbDatabase>,
     /// The object store name used for storing the data.
     pub object_store_name: String,
     /// The maximum number of queries used for the stream.
@@ -249,7 +249,7 @@ impl LocalAdminKeyValueStore for IndexedDbStore {
             }));
             database = db_req.await?;
         }
-        let database = Arc::new(database);
+        let database = Rc::new(database);
         let root_key = root_key.to_vec();
         Ok(IndexedDbStore {
             database,
@@ -374,11 +374,11 @@ pub enum IndexedDbStoreError {
     DatabaseConsistencyError(#[from] DatabaseConsistencyError),
 
     /// A DOM exception occurred in the IndexedDB operations
-    #[error("DOM exception: {}", self.to_string())]
+    #[error("DOM exception: {0:?}")]
     Dom(web_sys::DomException),
 
     /// JavaScript threw an exception whilst handling IndexedDB operations
-    #[error("JavaScript exception: {}", self.to_string())]
+    #[error("JavaScript exception: {0:?}")]
     Js(wasm_bindgen::JsValue),
 }