Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm-objcopy --redefine-syms Does Not Update Symbols in PE/COFF (.dll) Files #129366

Open
Harishmcw opened this issue Mar 1, 2025 · 1 comment

Comments

@Harishmcw
Copy link

Hi Developers,

When using llvm-objcopy on a PE/COFF .dll file to rename symbols using the --redefine-syms option, the command executes successfully, and the timestamp of the file updates. However, when inspecting the modified .dll, the symbols remain unchanged.

Command Executed:

llvm-objcopy --redefine-syms objcopy.def openblas.dll

Definition File (objcopy.def):

lsame_ scipy_lsame_
xerbla_ scipy_xerbla_
isamax_ scipy_isamax_
isamin_ scipy_isamin_
ismax_ scipy_ismax_

Please confirm whether --redefine-syms is expected to work on PE/COFF .dll files. If not, should it be documented as unsupported? Otherwise, if this is a bug, a fix would be greatly appreciated.

@llvmbot
Copy link
Member

llvmbot commented Mar 1, 2025

@llvm/issue-subscribers-tools-llvm-objcopy-strip

Author: None (Harishmcw)

Hi Developers,

When using llvm-objcopy on a PE/COFF .dll file to rename symbols using the --redefine-syms option, the command executes successfully, and the timestamp of the file updates. However, when inspecting the modified .dll, the symbols remain unchanged.

Command Executed:

llvm-objcopy --redefine-syms objcopy.def openblas.dll

Definition File (objcopy.def):

lsame_ scipy_lsame_
xerbla_ scipy_xerbla_
isamax_ scipy_isamax_
isamin_ scipy_isamin_
ismax_ scipy_ismax_

Please confirm whether --redefine-syms is expected to work on PE/COFF .dll files. If not, should it be documented as unsupported? Otherwise, if this is a bug, a fix would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants