Add reboot loop protection

Author: mpatnode

README.md

@@ -1,7 +1,11 @@
-# Raspberry Pi / Linux Network Repair Automation
+# Network Repair/Reboot Automation
 > This bash script checks the health status for either wired or wireless internet connection and, if it is failing, tries to fix it.   
 
-## Prerequisite - Mandatory
+## Tested Platforms
+Raspberry Pi Linux
+ReadyNAS 6.10.3
+
+## Prerequisites
 
 You at least need the "ping" command which should exist on most systems which already have networking.  If not the following should get you there:
 
@@ -15,7 +19,7 @@ You at least need the "ping" command which should exist on most systems which al
 `sudo crontab -e` 
 - Add to your crontab the following line, it will execute the check every minute. Please customize the script path according to the folder where you cloned the repo:  
 `* * * * * /yourpath/network_check.sh >> /var/log/netcheck.log 2>&1`
-- If you also want to reboot in case wifi is not working after the fix customize the reboot_server variable accordigly editing the script:  
+- If you also want to reboot in case the network is not working after the fix customize the reboot_server variable accordigly editing the script:  
 `nano network_check.sh`  
 
 ## Optional - Push notifications / Email

network_check.sh

@@ -10,13 +10,17 @@
 
 # Set gateway_ip to the gateway that you want to check to declare network working or not
 gateway_ip='1.1.1.1'
-# Set nic to your Network card name, as seen in ifconfig output
+# Set nic to your Network card name, as seen in ip output
 nic='wlan0'
 # Set network_check_threshold to the maximum number of failed checks
 network_check_threshold=5
 # Set reboot_server to true if you want to reboot as a last
-# option to fix wifi if ifconfig up/down
+# option to fix wifi if ip up/down fail
 reboot_server=false
+# to prevent reboot loops, only reboot once every N minutes
+reboot_cycle=60
+# last boot file
+last_bootfile=/root/.last_net_autoboot
 
 ###
 # Script logic
@@ -30,7 +34,7 @@ function date_log {
 }
 
 function restart_wlan {
-    # Trying wlan restart using ifconfig
+    # Trying wlan restart using ip
     date_log "Network was not working for the previous $network_check_tries checks."
     date_log "Restarting $nic"
     /sbin/ip link set "$nic" down
@@ -41,9 +45,15 @@ function restart_wlan {
     # If network is still down and reboot_server is set to true reboot
     ping -c 1 $gateway_ip > /dev/null 2>&1
     if [[ $? != 0 ]]; then
-        if [ "$reboot_server" = true ] ; then
-            date_log "Network is still not working, rebooting"
-            /sbin/reboot
+        if [ "$reboot_server" = true ]; then
+            # if there's no last boot file or it's older than reboot_cycle
+            if [[ ! -f $last_bootfile || $(find $last_bootfile -mtime +$reboot_cycle -print) ]]; then
+                touch $last_bootfile
+                date_log "Network is still not working, rebooting"
+                /sbin/reboot
+            else
+                date_log "Last auto reboot was less than $reboot_cycle minutes old"
+            fi
         fi
     fi
 }