fix: fix issue 1444 enhancement with specific error-handling

Separate error handling for the onPluginInit execution within
instantiatePlugin

Closes: hyperledger-cacti#1444
Signed-off-by: Michael Courtin <[email protected]>

Author: m-courtin

packages/cactus-cmd-api-server/src/main/typescript/api-server.ts

@@ -334,7 +334,23 @@ export class ApiServer {
     const plugin = await pluginFactory.create(pluginOptions);
 
     // need to invoke the i-cactus-plugin onPluginInit functionality here before plugin registry can be used further
-    await plugin.onPluginInit();
+    try {
+      await plugin.onPluginInit();
+    } catch (error) {
+      const fnTag = `${this.className}#instantiatePlugin`;
+      const packageName = plugin.getPackageName();
+      const instanceId = plugin.getInstanceId();
+
+      const errorMessage = `${fnTag} failed calling onPluginInit() on the plugin '${packageName}' with the instanceId '${instanceId}'`;
+
+      this.log.error(errorMessage, error);
+
+      if (error instanceof Error) {
+        throw new RuntimeError(errorMessage, error);
+      } else {
+        throw new RuntimeError(errorMessage, JSON.stringify(error));
+      }
+    }
 
     return plugin;
   }