Use immutable reference in a few places where now necessary

madsmtm · madsmtm · commit c71be858babc · 2023-08-01T13:49:58.000+02:00
See madsmtm/objc2#150 for a bit of background
diff --git a/src/input/appkit.rs b/src/input/appkit.rs
@@ -6,25 +6,25 @@ use crate::input::{TextFieldDelegate, TEXTFIELD_DELEGATE_PTR};
 use crate::utils::load;
 
 /// Called when editing this text field has ended (e.g. user pressed enter).
-extern "C" fn text_did_end_editing<T: TextFieldDelegate>(this: &mut Object, _: Sel, _info: id) {
+extern "C" fn text_did_end_editing<T: TextFieldDelegate>(this: &Object, _: Sel, _info: id) {
     let view = load::<T>(this, TEXTFIELD_DELEGATE_PTR);
     let s = NSString::retain(unsafe { msg_send![this, stringValue] });
     view.text_did_end_editing(s.to_str());
 }
 
-extern "C" fn text_did_begin_editing<T: TextFieldDelegate>(this: &mut Object, _: Sel, _info: id) {
+extern "C" fn text_did_begin_editing<T: TextFieldDelegate>(this: &Object, _: Sel, _info: id) {
     let view = load::<T>(this, TEXTFIELD_DELEGATE_PTR);
     let s = NSString::retain(unsafe { msg_send![this, stringValue] });
     view.text_did_begin_editing(s.to_str());
 }
 
-extern "C" fn text_did_change<T: TextFieldDelegate>(this: &mut Object, _: Sel, _info: id) {
+extern "C" fn text_did_change<T: TextFieldDelegate>(this: &Object, _: Sel, _info: id) {
     let view = load::<T>(this, TEXTFIELD_DELEGATE_PTR);
     let s = NSString::retain(unsafe { msg_send![this, stringValue] });
     view.text_did_change(s.to_str());
 }
 
-extern "C" fn text_should_begin_editing<T: TextFieldDelegate>(this: &mut Object, _: Sel, _info: id) -> BOOL {
+extern "C" fn text_should_begin_editing<T: TextFieldDelegate>(this: &Object, _: Sel, _info: id) -> BOOL {
     let view = load::<T>(this, TEXTFIELD_DELEGATE_PTR);
     let s = NSString::retain(unsafe { msg_send![this, stringValue] });
 
@@ -34,7 +34,7 @@ extern "C" fn text_should_begin_editing<T: TextFieldDelegate>(this: &mut Object,
     }
 }
 
-extern "C" fn text_should_end_editing<T: TextFieldDelegate>(this: &mut Object, _: Sel, _info: id) -> BOOL {
+extern "C" fn text_should_end_editing<T: TextFieldDelegate>(this: &Object, _: Sel, _info: id) -> BOOL {
     let view = load::<T>(this, TEXTFIELD_DELEGATE_PTR);
     let s = NSString::retain(unsafe { msg_send![this, stringValue] });
     match view.text_should_end_editing(s.to_str()) {
diff --git a/src/input/uikit.rs b/src/input/uikit.rs
@@ -10,25 +10,25 @@ use crate::input::{TextFieldDelegate, TEXTFIELD_DELEGATE_PTR};
 use crate::utils::load;
 
 /// Called when editing this text field has ended (e.g. user pressed enter).
-extern "C" fn text_did_end_editing<T: TextFieldDelegate>(this: &mut Object, _: Sel, _info: id) {
+extern "C" fn text_did_end_editing<T: TextFieldDelegate>(this: &Object, _: Sel, _info: id) {
     let view = load::<T>(this, TEXTFIELD_DELEGATE_PTR);
     let s = NSString::retain(unsafe { msg_send![this, text] });
     view.text_did_end_editing(s.to_str());
 }
 
-extern "C" fn text_did_begin_editing<T: TextFieldDelegate>(this: &mut Object, _: Sel, _info: id) {
+extern "C" fn text_did_begin_editing<T: TextFieldDelegate>(this: &Object, _: Sel, _info: id) {
     let view = load::<T>(this, TEXTFIELD_DELEGATE_PTR);
     let s = NSString::retain(unsafe { msg_send![this, text] });
     view.text_did_begin_editing(s.to_str());
 }
 
-extern "C" fn text_did_change<T: TextFieldDelegate>(this: &mut Object, _: Sel, _info: id) {
+extern "C" fn text_did_change<T: TextFieldDelegate>(this: &Object, _: Sel, _info: id) {
     let view = load::<T>(this, TEXTFIELD_DELEGATE_PTR);
     let s = NSString::retain(unsafe { msg_send![this, text] });
     view.text_did_change(s.to_str());
 }
 
-extern "C" fn text_should_begin_editing<T: TextFieldDelegate>(this: &mut Object, _: Sel, _info: id) -> BOOL {
+extern "C" fn text_should_begin_editing<T: TextFieldDelegate>(this: &Object, _: Sel, _info: id) -> BOOL {
     let view = load::<T>(this, TEXTFIELD_DELEGATE_PTR);
     let s = NSString::retain(unsafe { msg_send![this, text] });
 
@@ -38,7 +38,7 @@ extern "C" fn text_should_begin_editing<T: TextFieldDelegate>(this: &mut Object,
     }
 }
 
-extern "C" fn text_should_end_editing<T: TextFieldDelegate>(this: &mut Object, _: Sel, _info: id) -> BOOL {
+extern "C" fn text_should_end_editing<T: TextFieldDelegate>(this: &Object, _: Sel, _info: id) -> BOOL {
     let view = load::<T>(this, TEXTFIELD_DELEGATE_PTR);
     let s = NSString::retain(unsafe { msg_send![this, text] });
     match view.text_should_end_editing(s.to_str()) {
diff --git a/src/view/controller/appkit.rs b/src/view/controller/appkit.rs
@@ -11,7 +11,7 @@ use crate::utils::load;
 use crate::view::{ViewDelegate, VIEW_DELEGATE_PTR};
 
 /// Called when the view controller receives a `viewWillAppear` message.
-extern "C" fn will_appear<T: ViewDelegate>(this: &mut Object, _: Sel) {
+extern "C" fn will_appear<T: ViewDelegate>(this: &Object, _: Sel) {
     unsafe {
         let _: () = msg_send![super(this, class!(NSViewController)), viewWillAppear];
     }
@@ -21,7 +21,7 @@ extern "C" fn will_appear<T: ViewDelegate>(this: &mut Object, _: Sel) {
 }
 
 /// Called when the view controller receives a `viewDidAppear` message.
-extern "C" fn did_appear<T: ViewDelegate>(this: &mut Object, _: Sel) {
+extern "C" fn did_appear<T: ViewDelegate>(this: &Object, _: Sel) {
     unsafe {
         let _: () = msg_send![super(this, class!(NSViewController)), viewDidAppear];
     }
@@ -31,7 +31,7 @@ extern "C" fn did_appear<T: ViewDelegate>(this: &mut Object, _: Sel) {
 }
 
 /// Called when the view controller receives a `viewWillDisappear` message.
-extern "C" fn will_disappear<T: ViewDelegate>(this: &mut Object, _: Sel) {
+extern "C" fn will_disappear<T: ViewDelegate>(this: &Object, _: Sel) {
     unsafe {
         let _: () = msg_send![super(this, class!(NSViewController)), viewWillDisappear];
     }
@@ -41,7 +41,7 @@ extern "C" fn will_disappear<T: ViewDelegate>(this: &mut Object, _: Sel) {
 }
 
 /// Called when the view controller receives a `viewDidDisappear` message.
-extern "C" fn did_disappear<T: ViewDelegate>(this: &mut Object, _: Sel) {
+extern "C" fn did_disappear<T: ViewDelegate>(this: &Object, _: Sel) {
     unsafe {
         let _: () = msg_send![super(this, class!(NSViewController)), viewDidDisappear];
     }
diff --git a/src/view/controller/uikit.rs b/src/view/controller/uikit.rs
@@ -11,7 +11,7 @@ use crate::utils::load;
 use crate::view::{ViewDelegate, VIEW_DELEGATE_PTR};
 
 /// Called when the view controller receives a `viewWillAppear:` message.
-extern "C" fn will_appear<T: ViewDelegate>(this: &mut Object, _: Sel, animated: BOOL) {
+extern "C" fn will_appear<T: ViewDelegate>(this: &Object, _: Sel, animated: BOOL) {
     unsafe {
         let _: () = msg_send![super(this, class!(UIViewController)), viewWillAppear: animated];
     }
@@ -21,7 +21,7 @@ extern "C" fn will_appear<T: ViewDelegate>(this: &mut Object, _: Sel, animated:
 }
 
 /// Called when the view controller receives a `viewDidAppear:` message.
-extern "C" fn did_appear<T: ViewDelegate>(this: &mut Object, _: Sel, animated: BOOL) {
+extern "C" fn did_appear<T: ViewDelegate>(this: &Object, _: Sel, animated: BOOL) {
     unsafe {
         let _: () = msg_send![super(this, class!(UIViewController)), viewDidAppear: animated];
     }
@@ -31,7 +31,7 @@ extern "C" fn did_appear<T: ViewDelegate>(this: &mut Object, _: Sel, animated: B
 }
 
 /// Called when the view controller receives a `viewWillDisappear:` message.
-extern "C" fn will_disappear<T: ViewDelegate>(this: &mut Object, _: Sel, animated: BOOL) {
+extern "C" fn will_disappear<T: ViewDelegate>(this: &Object, _: Sel, animated: BOOL) {
     unsafe {
         let _: () = msg_send![super(this, class!(UIViewController)), viewWillDisappear: animated];
     }
@@ -41,7 +41,7 @@ extern "C" fn will_disappear<T: ViewDelegate>(this: &mut Object, _: Sel, animate
 }
 
 /// Called when the view controller receives a `viewDidDisappear:` message.
-extern "C" fn did_disappear<T: ViewDelegate>(this: &mut Object, _: Sel, animated: BOOL) {
+extern "C" fn did_disappear<T: ViewDelegate>(this: &Object, _: Sel, animated: BOOL) {
     unsafe {
         let _: () = msg_send![super(this, class!(UIViewController)), viewDidDisappear: animated];
     }

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ use crate::utils::load;`
`11`	`11`	`use crate::view::{ViewDelegate, VIEW_DELEGATE_PTR};`
`12`	`12`
`13`	`13`	/// Called when the view controller receives a `viewWillAppear` message.
`14`		`-extern "C" fn will_appear<T: ViewDelegate>(this: &mut Object, _: Sel) {`
	`14`	`+extern "C" fn will_appear<T: ViewDelegate>(this: &Object, _: Sel) {`
`15`	`15`	`unsafe {`
`16`	`16`	`let _: () = msg_send![super(this, class!(NSViewController)), viewWillAppear];`
`17`	`17`	`}`
`@@ -21,7 +21,7 @@ extern "C" fn will_appear<T: ViewDelegate>(this: &mut Object, _: Sel) {`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	/// Called when the view controller receives a `viewDidAppear` message.
`24`		`-extern "C" fn did_appear<T: ViewDelegate>(this: &mut Object, _: Sel) {`
	`24`	`+extern "C" fn did_appear<T: ViewDelegate>(this: &Object, _: Sel) {`
`25`	`25`	`unsafe {`
`26`	`26`	`let _: () = msg_send![super(this, class!(NSViewController)), viewDidAppear];`
`27`	`27`	`}`
`@@ -31,7 +31,7 @@ extern "C" fn did_appear<T: ViewDelegate>(this: &mut Object, _: Sel) {`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	/// Called when the view controller receives a `viewWillDisappear` message.
`34`		`-extern "C" fn will_disappear<T: ViewDelegate>(this: &mut Object, _: Sel) {`
	`34`	`+extern "C" fn will_disappear<T: ViewDelegate>(this: &Object, _: Sel) {`
`35`	`35`	`unsafe {`
`36`	`36`	`let _: () = msg_send![super(this, class!(NSViewController)), viewWillDisappear];`
`37`	`37`	`}`
`@@ -41,7 +41,7 @@ extern "C" fn will_disappear<T: ViewDelegate>(this: &mut Object, _: Sel) {`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	/// Called when the view controller receives a `viewDidDisappear` message.
`44`		`-extern "C" fn did_disappear<T: ViewDelegate>(this: &mut Object, _: Sel) {`
	`44`	`+extern "C" fn did_disappear<T: ViewDelegate>(this: &Object, _: Sel) {`
`45`	`45`	`unsafe {`
`46`	`46`	`let _: () = msg_send![super(this, class!(NSViewController)), viewDidDisappear];`
`47`	`47`	`}`