Skip to content

Commit ede1d08

Browse files
author
Vitaliy Boyko
committed
Clean up in observer declaration
1 parent 01c4d62 commit ede1d08

File tree

1 file changed

+10
-14
lines changed

1 file changed

+10
-14
lines changed

src/com/magento/idea/magento2plugin/inspections/xml/ObserverDeclarationInspection.java

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -121,25 +121,21 @@ public void visitFile(final PsiFile file) {
121121
file
122122
);
123123

124-
if (observerDisabledAttribute != null
125-
&& observerDisabledAttribute.getValue() != null
126-
&& observerDisabledAttribute.getValue().equals("true")
127-
&& modulesWithSameObserverName.isEmpty()
128-
) {
129-
problemsHolder.registerProblem(
130-
observerNameAttribute.getValueElement(),
131-
inspectionBundle.message(
132-
"inspection.observer.disabledObserverDoesNotExist"
133-
),
134-
errorSeverity
135-
);
136-
}
137-
138124
if (observerDisabledAttribute != null
139125
&& observerDisabledAttribute.getValue() != null
140126
&& observerDisabledAttribute.getValue().equals("true")
141127
) {
128+
if (modulesWithSameObserverName.isEmpty()) {
129+
problemsHolder.registerProblem(
130+
observerNameAttribute.getValueElement(),
131+
inspectionBundle.message(
132+
"inspection.observer.disabledObserverDoesNotExist"
133+
),
134+
errorSeverity
135+
);
136+
} else {
142137
continue;
138+
}
143139
}
144140

145141
for (final HashMap<String, String> moduleEntry:

0 commit comments

Comments
 (0)