-
Notifications
You must be signed in to change notification settings - Fork 658
Replace canvas with @napi-rs/canvas #1296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If someone wanted to make a PR it would be great to test the difference. Is the platform support the same (macos/linux/windows)? |
Due to Automattic/node-canvas#2448 this might also be required to avoid problems with recent node versions |
As per the library intro, it is zero dependencies. Also its still in pre-release and not fully supporting all functions yet as per Brooooooklyn/canvas#113 However, we can test it out first since the performance is much desirable. |
I made the switch for a very small project. It was very seamless and immediately fixed a bunch of issues caused by node-canvas memory management bugs. YMMV but my experience with @napi-rs/canvas was fantastic. |
A suggestion for performance improvements.
Reviewing at the benchmark in https://www.npmjs.com/package/@napi-rs/canvas, this will be quick win for faster canvas replacement.
Thanks for your consideration.
The text was updated successfully, but these errors were encountered: